linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Dave Peterson <dsp@llnl.gov>, linux-kernel@vger.kernel.org
Subject: Re: possible race condition in vfs code
Date: Wed, 30 Apr 2003 09:52:32 +0300	[thread overview]
Message-ID: <3EAF72B0.5040605@kolumbus.fi> (raw)
In-Reply-To: 20030429230316.GR10374@parcelfarce.linux.theplanet.co.uk


I mean busy inodes after umount doing bogus write_inode_now. Busy inodes 
don't pin the superblock (vfsmnt does but it's gone, otherwise we 
wouldn't be in kill_sb in the first place).

Dave Peterson's fix solves the double free issue, but does potentially 
introduce another busy inode after sb has gone.

--Mika



viro@parcelfarce.linux.theplanet.co.uk wrote:

>On Wed, Apr 30, 2003 at 01:51:42AM +0300, Mika Penttilä wrote:
>  
>
>>That piece of code looks wrong in other ways also..if we have unmounted 
>>an active fs (which shouldn't be done but happens!) we shouldn't be at 
>>least writing back to it anything! The !sb test isn't useful (we never 
>>clear it in live inodes) and MS_ACTIVE handling is racy as hell wrt 
>>umount...
>>    
>>
>
>Would you mind actually _reading_ kill_super() and stuff called by it?
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
>
>  
>



      reply	other threads:[~2003-04-30  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-15 16:22 possible race condition in vfs code Dave Peterson
2003-04-29 22:51 ` Mika Penttilä
2003-04-29 23:03   ` viro
2003-04-30  6:52     ` Mika Penttilä [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EAF72B0.5040605@kolumbus.fi \
    --to=mika.penttila@kolumbus.fi \
    --cc=dsp@llnl.gov \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).