From: Hans-Georg Thien <1682-600@onlinehome.de>
To: linux-kernel@vger.kernel.org
Cc: ak@suse.de
Subject: Re: [RFC][PATCH] "Disable Trackpad while typing" on Notebooks withh a PS/2 Trackpad
Date: Fri, 02 May 2003 13:44:03 +0200 [thread overview]
Message-ID: <3EB25A03.5010608@onlinehome.de> (raw)
In-Reply-To: <fa.ianmvqa.8le6bo@ifi.uio.no>
Andi Kleen wrote:
> Hans-Georg Thien <1682-600@onlinehome.de> writes:
>
>
>>The short story
>>---------------
>>The trackpad on the MacIntosh iBook Notebooks have a feature that
>>prevents unintended trackpad input while typing on the keyboard. There
>>are no mouse-moves or mouse-taps for a short period of time after each
>>keystroke.
>
>
> Very nice. In fact I wanted something like this for my ibook for a
> long time.
>
> But it won't work on an ibook of course because it doesn't use the
> pc_keyb driver. Instead it uses the Input layer for the adb device.
> In fact in 2.5 there is only the input layer for everything including
> PC keyboards. It should be probably moved there too.
>
Sounds good! I will look into 2.5 soon. But I fear that a lot of time
will pass until 2.6 is available and I think it is a good interim
solution for the 2.4 users.
> One suggestion: don't make it a CONFIG_*. Recompiling a kernel
> to change things like that is not good. Make it an ioctl that
> can be configured at runtime.
>
that's why I would prefer a LKM instead of a kernel patch. If you know a
clean way to save/restore irq-handlers please let me know. That would
also allow to make it portable to other platforms like Apple iBook or
notebooks with other than PS/2 trackpads.
Implementing an ioctl() is a nice idea too. But why not have it
configurable via the /proc interface? If you use ioctl() you still need
to write a userspace program. Ok, that's not difficult, but I think it's
more comfortable if you can simply use
#/etc/rc.d/trackpad, set trackpad delay time
echo "trackpad delay=2000" > /proc/something
#/etc/hotplug??? external mouse is just plugged in, disable trackpad
echo "trackpad disable=1" > /proc/something
#/etc/hotplug??? external mouse is just revmoved, re-enable trackpad
echo "trackpad disable=0" > /proc/something
> Another one: the disable_trackpad_timer_while_typing variable is not
> really needed. You can manage all state by checking the timer with
> timer_pending()
>
yes ok, so I can save one variable. But I would than have to make the
enable_trackpad_timer a static global var. That's not really bad, but I
feel that "complex datastructures" better hidden in a function, - but
it's only a "feeling"
-Hans
next parent reply other threads:[~2003-05-02 11:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.pum5p2l.umu1r1@ifi.uio.no>
[not found] ` <fa.ianmvqa.8le6bo@ifi.uio.no>
2003-05-02 11:44 ` Hans-Georg Thien [this message]
2003-05-02 9:41 [RFC][PATCH] "Disable Trackpad while typing" on Notebooks withh a PS/2 Trackpad Hans-Georg Thien
[not found] <3EB19625.6040904@onlinehome.de.suse.lists.linux.kernel>
2003-05-01 22:29 ` Andi Kleen
2003-05-05 22:48 ` Hans-Georg Thien
2003-05-06 9:04 ` Alex Riesen
[not found] ` <mailman.1052174881.22701.linux-kernel2news@redhat.com>
2003-05-06 3:24 ` Pete Zaitcev
-- strict thread matches above, loose matches on Subject: below --
2003-05-01 21:48 Hans-Georg Thien
2003-05-01 22:13 ` Måns Rullgård
2003-05-06 9:29 ` wwp
2003-05-06 11:27 ` Hans-Georg Thien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB25A03.5010608@onlinehome.de \
--to=1682-600@onlinehome.de \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).