linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
To: linux-kernel@vger.kernel.org
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
	Alexander Viro <viro@math.psu.edu>
Subject: PATCH: seq_file interface to provide large data chunks
Date: Thu, 10 Jul 2003 11:19:07 +0300	[thread overview]
Message-ID: <3F0D217B.4040900@intel.com> (raw)

seq_file interface, as it exist in last official kernel, never provides 
more then one page for each 'read' call. Old read_proc_t did loop to 
fill more than one page.

Following patch against 2.4.21 fixes seq_file to provide more than one 
page if user requests it.
Many programs do read(large_buffer) once, instead of looping while 
read()>0. They work wrong with seq_file. Also, one may expect read() to 
provide whole information atomically (OK, relatively to other process 
context stuff).
This patch loops over while some space remains in user provided buffer.

I am not subscribed to lkml, thus please cc: me (Vladimir Kondratiev 
<vladimir.kondratiev@intel.com>) explicitly.

--- linux-2.4.21/fs/seq_file.c    2003-06-13 17:51:37.000000000 +0300
+++ linux/fs/seq_file.c    2003-07-10 10:47:53.000000000 +0300
@@ -55,6 +55,7 @@
         return -EPIPE;
 
     down(&m->sem);
+Again:
     /* grab buffer if we didn't have one */
     if (!m->buf) {
         m->buf = kmalloc(m->size = PAGE_SIZE, GFP_KERNEL);
@@ -123,11 +124,14 @@
         goto Efault;
     copied += n;
     m->count -= n;
+    size -= n;
+    buf += n;
     if (m->count)
         m->from = n;
     else
         pos++;
     m->index = pos;
+    goto Again;
 Done:
     if (!copied)
         copied = err;



             reply	other threads:[~2003-07-10  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-10  8:19 Vladimir Kondratiev [this message]
2003-07-10 11:09 ` PATCH: seq_file interface to provide large data chunks Alan Cox
2003-07-10 12:12   ` Vladimir Kondratiev
2003-07-15 11:57   ` Vladimir Kondratiev
2003-07-11 15:13 ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F0D217B.4040900@intel.com \
    --to=vladimir.kondratiev@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).