From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
LSE <lse-tech@lists.sourceforge.net>,
Anton Blanchard <anton@samba.org>
Subject: Re: [Lse-tech] Re: 2.6.0-test9-mjb1
Date: Thu, 30 Oct 2003 16:37:54 -0500 [thread overview]
Message-ID: <3FA184B2.9030504@pobox.com> (raw)
In-Reply-To: <1067549370.2657.38.camel@nighthawk>
Dave Hansen wrote:
> On Thu, 2003-10-30 at 13:17, Jeff Garzik wrote:
>
>>well, there's still this patch...
>> void
>>-e1000_io_write(struct e1000_hw *hw, uint32_t port, uint32_t value)
>>+e1000_io_write(struct e1000_hw *hw, unsigned long port, uint32_t value)
>> {
>> outl(value, port);
>> }
>
>
> Whoops. I just went looking in the breakout directory and didn't see it
> in there. I wonder where it was hidden.
>
> Anton, did this come from you? Did it stop some warnings or something?
"stop some warnings"? ;) It's obviously correct -- a port address
_must_ be unsigned long. Anything less is uncivilized (and a bug).
Jeff
next prev parent reply other threads:[~2003-10-30 21:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-30 20:00 2.6.0-test9-mjb1 Martin J. Bligh
2003-10-30 20:17 ` 2.6.0-test9-mjb1 Jeff Garzik
2003-10-30 21:07 ` [Lse-tech] 2.6.0-test9-mjb1 Dave Hansen
2003-10-30 21:17 ` Jeff Garzik
2003-10-30 21:29 ` Dave Hansen
2003-10-30 21:37 ` Jeff Garzik [this message]
2003-11-03 21:32 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FA184B2.9030504@pobox.com \
--to=jgarzik@pobox.com \
--cc=anton@samba.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).