From: Dan Murphy <dmurphy@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
<lee.jones@linaro.org>, <tony@atomide.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [PATCH v3 4/9] dt-bindings: leds: Add bindings for lm3697 driver
Date: Fri, 19 Oct 2018 06:47:47 -0500 [thread overview]
Message-ID: <3b96b65f-edd6-aa13-9f47-cdc58eac6c9d@ti.com> (raw)
In-Reply-To: <20181012162702.GA5672@bogus>
Rob
Thanks for the review.
On 10/12/2018 11:27 AM, Rob Herring wrote:
> On Thu, Oct 11, 2018 at 11:51:18AM -0500, Dan Murphy wrote:
>> Add the device tree bindings for the lm3697
>> LED driver for backlighting and display.
>
> Bindings are for h/w, not drivers...
>
ACK
Dan
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> .../devicetree/bindings/leds/leds-lm3697.txt | 98 +++++++++++++++++++
>> 1 file changed, 98 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
>> new file mode 100644
>> index 000000000000..4bb2ed51025b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
>> @@ -0,0 +1,98 @@
>> +* Texas Instruments - LM3697 Highly Efficient White LED Driver
>> +
>> +The LM3697 11-bit LED driver provides high-
>> +performance backlight dimming for 1, 2, or 3 series
>> +LED strings while delivering up to 90% efficiency.
>> +
>> +This device is suitable for display and keypad Lighting
>> +
>> +Required properties:
>> + - compatible:
>> + "ti,lm3697"
>> + - reg : I2C slave address
>> + - #address-cells : 1
>> + - #size-cells : 0
>> +
>> +Optional properties:
>> + - enable-gpios : GPIO pin to enable/disable the device
>> + - vled-supply : LED supply
>> +
>> +Required child properties:
>> + - reg : 0 - LED is Controlled by bank A
>> + 1 - LED is Controlled by bank B
>> + - led-sources : Indicates which HVLED string is associated to which
>> + control bank. Each element in the array is associated
>> + with a specific HVLED string. Element 0 is HVLED1,
>> + element 1 is HVLED2 and element 2 HVLED3.
>> + Additional information is contained
>> + in Documentation/devicetree/bindings/leds/common.txt
>> + 0 - HVLED is not active in this control bank
>> + 1 - HVLED string is controlled by this control bank
>> +
>> +Optional child properties:
>> + - runtime-ramp-up-msec: Current ramping from one brightness level to
>> + the a higher brightness level.
>> + Range from 2048 us - 117.44 s
>> + - runtime-ramp-down-msec: Current ramping from one brightness level to
>> + the a lower brightness level.
>> + Range from 2048 us - 117.44 s
>> + - label : see Documentation/devicetree/bindings/leds/common.txt
>> + - linux,default-trigger :
>> + see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +HVLED string 1 and 3 are controlled by control bank A and HVLED 2 string is
>> +controlled by control bank B.
>> +
>> +led-controller@36 {
>> + compatible = "ti,lm3697";
>> + reg = <0x36>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> + vled-supply = <&vbatt>;
>> +
>> + led@0 {
>> + reg = <0>;
>> + led-sources = <1 0 1>;
>> + runtime-ramp-up-msec = <5000>;
>> + runtime-ramp-down-msec = <1000>;
>> + label = "white:first_backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> +
>> + led@1 {
>> + reg = <1>;
>> + led-sources = <0 1 0>;
>> + runtime-ramp-up-msec = <500>;
>> + runtime-ramp-down-msec = <1000>;
>> + label = "white:second_backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> +}
>> +
>> +All HVLED strings controlled by control bank A
>> +
>> +led-controller@36 {
>> + compatible = "ti,lm3697";
>> + reg = <0x36>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> + vled-supply = <&vbatt>;
>> +
>> + led@0 {
>> + reg = <0>;
>> + led-sources = <1 1 1>;
>> + runtime-ramp-up-msec = <500>;
>> + runtime-ramp-down-msec = <1000>;
>> + label = "white:backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> +}
>> +
>> +For more product information please see the link below:
>> +http://www.ti.com/lit/ds/symlink/lm3697.pdf
>> --
>> 2.19.0
>>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2018-10-19 11:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 16:51 [PATCH v3 0/9] TI LMU common Framework Dan Murphy
2018-10-11 16:51 ` [PATCH v3 1/9] leds: add TI LMU backlight driver Dan Murphy
2018-10-11 16:51 ` [PATCH v3 2/9] dt-bindings: ti-lmu: Remove LM3697 Dan Murphy
2018-10-11 18:27 ` Pavel Machek
2018-10-11 18:34 ` Dan Murphy
2018-10-11 19:38 ` Jacek Anaszewski
2018-10-12 16:26 ` Rob Herring
2018-10-12 18:03 ` Pavel Machek
2018-10-13 18:45 ` Jacek Anaszewski
2018-10-15 0:56 ` Rob Herring
2018-10-15 19:13 ` Jacek Anaszewski
2018-10-15 19:14 ` Dan Murphy
2018-10-15 21:45 ` Pavel Machek
2018-10-16 13:25 ` Dan Murphy
2018-10-18 22:10 ` Pavel Machek
2018-10-19 11:42 ` Dan Murphy
2018-10-19 14:58 ` Tony Lindgren
2018-10-24 8:55 ` Pavel Machek
2018-10-12 9:07 ` Lee Jones
2018-10-11 16:51 ` [PATCH v3 3/9] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2018-10-11 16:51 ` [PATCH v3 4/9] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-10-12 16:27 ` Rob Herring
2018-10-19 11:47 ` Dan Murphy [this message]
2018-10-11 16:51 ` [PATCH v3 5/9] leds: lm3697: Introduce the " Dan Murphy
2018-10-11 16:51 ` [PATCH v3 6/9] dt-bindings: ti-lmu: Remove LM3633 Dan Murphy
2018-10-11 16:51 ` [PATCH v3 7/9] mfd: ti-lmu: Remove support for LM3633 Dan Murphy
2018-10-11 16:51 ` [PATCH v3 8/9] dt-bindings: leds: Add support for the LM3633 Dan Murphy
2018-10-11 16:51 ` [PATCH v3 9/9] leds: lm3633: Introduce the lm3633 driver Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b96b65f-edd6-aa13-9f47-cdc58eac6c9d@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).