From: Yunsheng Lin <linyunsheng@huawei.com>
To: Jason Wang <jasowang@redhat.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <mst@redhat.com>
Cc: <brouer@redhat.com>, <paulmck@kernel.org>, <peterz@infradead.org>,
<will@kernel.org>, <shuah@kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linuxarm@openeuler.org>
Subject: Re: [PATCH net-next v2 1/2] selftests/ptr_ring: add benchmark application for ptr_ring
Date: Fri, 25 Jun 2021 11:52:16 +0800 [thread overview]
Message-ID: <3ba4a6f1-2e1e-8c1a-6f47-5d182f05d1cd@huawei.com> (raw)
In-Reply-To: <ff47ed0b-332d-2772-d6e1-8277ac602c8c@redhat.com>
On 2021/6/25 11:36, Jason Wang wrote:
>
> 在 2021/6/25 上午11:18, Yunsheng Lin 写道:
>> Currently ptr_ring selftest is embedded within the virtio
>> selftest, which involves some specific virtio operation,
>> such as notifying and kicking.
>>
>> As ptr_ring has been used by various subsystems, it deserves
>> it's owner's selftest in order to benchmark different usecase
>> of ptr_ring, such as page pool and pfifo_fast qdisc.
>>
>> So add a simple application to benchmark ptr_ring performance.
>> Currently two test mode is supported:
>> Mode 0: Both enqueuing and dequeuing is done in a single thread,
>> it is called simple test mode in the test app.
>> Mode 1: Enqueuing and dequeuing is done in different thread
>> concurrently, also known as SPSC(single-producer/
>> single-consumer) test.
>>
>> The multi-producer/single-consumer test for pfifo_fast case is
>> not added yet, which can be added if using CAS atomic operation
>> to enable lockless multi-producer is proved to be better than
>> using r->producer_lock.
>>
>> Only supported on x86 and arm64 for now.
>>
>> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
>> ---
>> MAINTAINERS | 5 +
>> tools/testing/selftests/ptr_ring/Makefile | 6 +
>> tools/testing/selftests/ptr_ring/ptr_ring_test.c | 249 +++++++++++++++++++++++
>> tools/testing/selftests/ptr_ring/ptr_ring_test.h | 150 ++++++++++++++
>> 4 files changed, 410 insertions(+)
>
>
> Why can't you simply reuse tools/virtio/ringtest?
The main reason is stated in the commit log:
"Currently ptr_ring selftest is embedded within the virtio
selftest, which involves some specific virtio operation,
such as notifying and kicking.
As ptr_ring has been used by various subsystems, it deserves
it's owner's selftest in order to benchmark different usecase
of ptr_ring, such as page pool and pfifo_fast qdisc."
More specificly in tools/virtio/ringtest/main.c and
tools/virtio/ringtest/ptr_ring.c, there are a lot of operation
related to virtio usecase, such as start_guest(), start_host(),
poll_used(), notify() or kick() ....., so it makes more sense
to add a generic selftest for ptr ring as it is not only used
by virtio now.
>
> Thanks
>
>
> .
>
next prev parent reply other threads:[~2021-06-25 3:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 3:18 [PATCH net-next v2 0/2] add benchmark selftest and optimization for ptr_ring Yunsheng Lin
2021-06-25 3:18 ` [PATCH net-next v2 1/2] selftests/ptr_ring: add benchmark application " Yunsheng Lin
2021-06-25 3:36 ` Jason Wang
2021-06-25 3:52 ` Yunsheng Lin [this message]
2021-06-27 6:09 ` Michael S. Tsirkin
2021-06-28 1:42 ` Yunsheng Lin
2021-06-25 6:37 ` Michael S. Tsirkin
2021-06-25 7:40 ` Yunsheng Lin
2021-06-25 3:18 ` [PATCH net-next v2 2/2] ptr_ring: make __ptr_ring_empty() checking more reliable Yunsheng Lin
2021-06-25 6:32 ` Michael S. Tsirkin
2021-06-25 7:21 ` Yunsheng Lin
2021-06-25 7:30 ` Michael S. Tsirkin
2021-06-25 8:33 ` Yunsheng Lin
2021-06-27 6:03 ` Michael S. Tsirkin
2021-06-28 2:17 ` Yunsheng Lin
2021-06-25 6:39 ` Michael S. Tsirkin
2021-06-25 9:20 ` Yunsheng Lin
2021-06-27 6:07 ` Michael S. Tsirkin
2021-06-28 2:11 ` [Linuxarm] " Yunsheng Lin
2021-06-25 6:42 ` [PATCH net-next v2 0/2] add benchmark selftest and optimization for ptr_ring Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba4a6f1-2e1e-8c1a-6f47-5d182f05d1cd@huawei.com \
--to=linyunsheng@huawei.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).