From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: jejb@linux.ibm.com, Jarkko Sakkinen <jarkko@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
Jonathan Corbet <corbet@lwn.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH 1/2] crypto: use SM3 instead of SM3_256
Date: Tue, 19 Oct 2021 17:35:05 +0800 [thread overview]
Message-ID: <3bd42726-b383-eb33-5c03-2932036d06a4@linux.alibaba.com> (raw)
In-Reply-To: <7035153d58e220473fe3cd17c9f574f2d91c740b.camel@linux.ibm.com>
Hi James,
On 10/18/21 9:05 PM, James Bottomley wrote:
> On Sat, 2021-10-09 at 21:08 +0800, Tianjia Zhang wrote:
> [...]
>> diff --git a/include/uapi/linux/hash_info.h
>> b/include/uapi/linux/hash_info.h
>> index 74a8609fcb4d..1355525dd4aa 100644
>> --- a/include/uapi/linux/hash_info.h
>> +++ b/include/uapi/linux/hash_info.h
>> @@ -32,7 +32,7 @@ enum hash_algo {
>> HASH_ALGO_TGR_128,
>> HASH_ALGO_TGR_160,
>> HASH_ALGO_TGR_192,
>> - HASH_ALGO_SM3_256,
>> + HASH_ALGO_SM3,
>> HASH_ALGO_STREEBOG_256,
>> HASH_ALGO_STREEBOG_512,
>> HASH_ALGO__LAST
>
> This is another one you can't do: all headers in UAPI are exports to
> userspace and the definitions constitute an ABI. If you simply do a
> rename, every userspace program that uses the current definition will
> immediately break on compile. You could add HASH_ALGO_SM3, but you
> can't remove HASH_ALGO_SM3_256
>
> James
>
Correct, Thanks for pointing it out, redefining a macro is indeed a more
appropriate method.
Best regards,
Tianjia
next prev parent reply other threads:[~2021-10-19 9:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 13:08 [PATCH 0/2] tpm: use SM3 instead of SM3_256 Tianjia Zhang
2021-10-09 13:08 ` [PATCH 1/2] crypto: " Tianjia Zhang
2021-10-18 13:05 ` James Bottomley
2021-10-18 13:27 ` Jarkko Sakkinen
2021-10-18 13:32 ` James Bottomley
2021-10-18 13:41 ` Jarkko Sakkinen
2021-10-19 9:39 ` Tianjia Zhang
2021-10-19 9:35 ` Tianjia Zhang [this message]
2021-10-09 13:08 ` [PATCH 2/2] tpm: " Tianjia Zhang
2021-10-12 15:21 ` Jarkko Sakkinen
2021-10-14 9:46 ` Tianjia Zhang
2021-10-15 15:19 ` Jarkko Sakkinen
2021-10-18 2:37 ` Tianjia Zhang
2021-10-18 12:48 ` Jarkko Sakkinen
2021-10-09 13:29 ` [PATCH 0/2] " James Bottomley
2021-10-11 7:02 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bd42726-b383-eb33-5c03-2932036d06a4@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).