From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP
Date: Tue, 27 Sep 2022 07:42:36 +0200 [thread overview]
Message-ID: <3dba20a4-20d0-6cff-68be-25e9ca365764@suse.com> (raw)
In-Reply-To: <b9c7a953-dbfa-164f-7a18-1e230c70e124@oracle.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 696 bytes --]
On 26.09.22 22:09, Boris Ostrovsky wrote:
>
> On 9/26/22 10:18 AM, Juergen Gross wrote:
>> bool pmu_msr_read(unsigned int msr, uint64_t *val, int *err)
>> {
>> if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) {
>> - if (is_amd_pmu_msr(msr)) {
>> - if (!xen_amd_pmu_emulate(msr, val, 1))
>> - *val = native_read_msr_safe(msr, err);
>> - return true;
>> + if (!is_amd_pmu_msr(msr))
>
>
> You should be able to move vendor check inside is_<vendor>_pmu_msr().
I like that. Together with Jan's suggestion this makes the code much
more readable!
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-09-27 5:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 14:18 [PATCH 0/3] xen/pv: sanitize xen pv guest msr accesses Juergen Gross
2022-09-26 14:18 ` [PATCH 1/3] xen/pv: allow pmu msr accesses to cause GP Juergen Gross
2022-09-26 15:29 ` Jan Beulich
2022-09-26 15:33 ` Juergen Gross
2022-09-26 20:09 ` Boris Ostrovsky
2022-09-27 5:42 ` Juergen Gross [this message]
2022-09-26 14:18 ` [PATCH 2/3] xen/pv: refactor msr access functions to support safe and unsafe accesses Juergen Gross
2022-09-26 14:18 ` [PATCH 3/3] xen/pv: support selecting safe/unsafe msr accesses Juergen Gross
2022-09-26 15:23 ` Jan Beulich
2022-09-26 15:36 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dba20a4-20d0-6cff-68be-25e9ca365764@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).