From: Jiri Slaby <jslaby@suse.cz>
To: Arnaud POULIQUEN <arnaud.pouliquen@st.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suman Anna <s-anna@ti.com>,
Fabien DESSENNE <fabien.dessenne@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
xiang xiao <xiaoxiang781216@gmail.com>
Subject: Re: [PATCH v7 2/2] tty: add rpmsg driver
Date: Thu, 26 Mar 2020 12:45:57 +0100 [thread overview]
Message-ID: <3e666fa0-2f4d-9958-887e-8830049ccbe8@suse.cz> (raw)
In-Reply-To: <2512639d-424f-9647-4dbd-3b3459465888@st.com>
On 26. 03. 20, 12:40, Arnaud POULIQUEN wrote:
>>>>> + /*
>>>>> + * Try to send the message to remote processor, if failed return 0 as
>>>>> + * no data sent
>>>>> + */
>>>>> + ret = rpmsg_trysendto(cport->d_ept, tmpbuf, msg_size, cport->data_dst);
>>>>
>>>> data of rpmsg_trysendto is not const. OK, you seem you need to change
>>>> that first, I see no blocker for that.
>>>
>>> I created a temporary buffer to ensure that buffer to sent does not exceed the
>>> MTU size.
>>> But perhaps this is an useless protection as the rpmsg_tty_write_room already
>>> return the MTU value, and so the 'len' variable can not be higher that value
>>> returned by the write_room?
>>
>> You still can limit it by msg_size without cloning the buffer, right?
> you are right, but in this case i need to cast the buff to suppress compilation
> warning on const and I don't know if all compilers will accept this...
>
> pbuf = (u8 *)buf;
> ret = rpmsg_trysendto(cport->d_ept, pbuf, msg_size, cport->data_dst);
No, don't do that. Read my first message again; in particular:
> data of rpmsg_trysendto is not const. OK, you seem you need to change
> that first, I see no blocker for that.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2020-03-26 11:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 17:04 [PATCH v7 0/2] Add rpmsg tty driver Arnaud Pouliquen
2020-03-24 17:04 ` [PATCH v7 1/2] rpmsg: core: add API to get MTU Arnaud Pouliquen
2020-03-31 17:36 ` Mathieu Poirier
2020-04-01 6:28 ` Jiri Slaby
2020-04-01 6:29 ` Jiri Slaby
2020-04-01 11:34 ` Arnaud POULIQUEN
2020-03-24 17:04 ` [PATCH v7 2/2] tty: add rpmsg driver Arnaud Pouliquen
2020-03-24 17:18 ` Greg Kroah-Hartman
2020-03-25 11:34 ` Arnaud POULIQUEN
2020-03-24 17:23 ` Joe Perches
2020-03-25 11:36 ` Arnaud POULIQUEN
2020-03-24 17:44 ` Randy Dunlap
2020-03-25 8:10 ` Jiri Slaby
2020-03-25 11:39 ` Arnaud POULIQUEN
2020-03-24 20:52 ` Bjorn Andersson
2020-03-25 16:57 ` Arnaud POULIQUEN
2020-04-06 14:18 ` Arnaud POULIQUEN
2020-05-06 2:54 ` Bjorn Andersson
2020-05-06 10:21 ` Arnaud POULIQUEN
2020-03-25 8:45 ` Jiri Slaby
2020-03-25 13:15 ` Arnaud POULIQUEN
2020-03-25 13:31 ` Jiri Slaby
2020-03-26 0:01 ` Joe Perches
2020-03-26 6:38 ` Jiri Slaby
2020-03-26 10:59 ` Arnaud POULIQUEN
2020-03-26 12:31 ` Jiri Slaby
2020-03-26 11:40 ` Arnaud POULIQUEN
2020-03-26 11:45 ` Jiri Slaby [this message]
2020-04-01 18:06 ` Mathieu Poirier
2020-04-02 15:25 ` Arnaud POULIQUEN
2020-04-03 20:18 ` Mathieu Poirier
2020-07-15 16:06 ` [PATCH v7 0/2] Add rpmsg tty driver Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e666fa0-2f4d-9958-887e-8830049ccbe8@suse.cz \
--to=jslaby@suse.cz \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.dessenne@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
--cc=xiaoxiang781216@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).