From: Sinan Kaya <okaya@kernel.org>
To: Borislav Petkov <bp@alien8.de>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>
Cc: linux-next@vger.kernel.org, linux-acpi@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>
Subject: Re: [for-next][PATCH] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
Date: Thu, 17 Jan 2019 11:39:33 -0500 [thread overview]
Message-ID: <3ef1915c-f3c0-84ea-d35e-c26a16e8f818@kernel.org> (raw)
In-Reply-To: <20190117163722.GE5023@zn.tnic>
On 1/17/2019 11:37 AM, Borislav Petkov wrote:
> On Thu, Jan 17, 2019 at 04:17:22PM +0000, Sinan Kaya wrote:
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly.
>>
>> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
>> mentioned in the Kconfig.
>>
>> Add an explicit dependency here.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>> arch/x86/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 568f339595ed..0519da6f8ee4 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -199,7 +199,7 @@ config X86
>> select IRQ_FORCED_THREADING
>> select NEED_SG_DMA_LENGTH
>> select PCI_DOMAINS if PCI
>> - select PCI_LOCKLESS_CONFIG
>> + select PCI_LOCKLESS_CONFIG if PCI
>> select PERF_EVENTS
>> select RTC_LIB
>> select RTC_MC146818_LIB
>> --
>
> Are there any more arch/x86/ fixes for the 5d32a66541c4 fallout floating
> around?
>
> If so, pls merge them all together into a single patch so that we're
> done with this once and for all.
>
> Also, I see a lot of build failures when doing randconfig builds for the
> stuff in drivers/platform/x86/Kconfig. Is someone picking those up too?
>
> If not, I'd take 'em too in a single patch, if Darren and Andy are fine
> with it.
I'm only looking at PCI and ACPI related changes to be honest. The rest is
out of my expertise area.
I started a run of 1000 randconfig runs in the meantime. I'll collect the
results soon and follow up if there is something I can help.
>
> Thx.
>
next prev parent reply other threads:[~2019-01-17 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 16:17 [for-next][PATCH] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled Sinan Kaya
2019-01-17 16:37 ` Borislav Petkov
2019-01-17 16:39 ` Sinan Kaya [this message]
2019-01-17 16:42 ` Sinan Kaya
2019-01-17 21:56 ` Borislav Petkov
2019-01-17 22:05 ` Rafael J. Wysocki
2019-01-17 22:09 ` Borislav Petkov
2019-01-17 23:02 ` Sinan Kaya
2019-01-18 11:45 ` Rafael J. Wysocki
2019-01-21 23:18 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ef1915c-f3c0-84ea-d35e-c26a16e8f818@kernel.org \
--to=okaya@kernel.org \
--cc=andy@infradead.org \
--cc=bp@alien8.de \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).