From: Randy Dunlap <rdunlap@infradead.org>
To: "Arnd Bergmann" <arnd@arndb.de>, "Jason Gunthorpe" <jgg@ziepe.ca>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Jérôme Glisse" <jglisse@redhat.com>
Cc: Jason Gunthorpe <jgg@mellanox.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Changbin Du <changbin.du@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] HMM: test: fix CONFIG_DEVICE_PRIVATE dependencies
Date: Fri, 8 May 2020 11:05:30 -0700 [thread overview]
Message-ID: <3f55d763-9017-16e5-5765-75634c0c0c0c@infradead.org> (raw)
In-Reply-To: <20200508144017.3501418-1-arnd@arndb.de>
On 5/8/20 7:40 AM, Arnd Bergmann wrote:
> One cannot select DEVICE_PRIVATE when its dependencies are disabled:
>
> WARNING: unmet direct dependencies detected for DEVICE_PRIVATE
> Depends on [n]: ZONE_DEVICE [=n]
> Selected by [m]:
> - TEST_HMM [=m] && RUNTIME_TESTING_MENU [=y] && TRANSPARENT_HUGEPAGE [=y]
> lib/test_hmm.c:480:8: error: implicit declaration of function 'memremap_pages' [-Werror,-Wimplicit-function-declaration]
> ptr = memremap_pages(&devmem->pagemap, numa_node_id());
> ^
> lib/test_hmm.c:480:8: note: did you mean 'memcmp_pages'?
> include/linux/mm.h:3082:12: note: 'memcmp_pages' declared here
> extern int memcmp_pages(struct page *page1, struct page *page2);
> ^
> lib/test_hmm.c:480:6: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Werror,-Wint-conversion]
> ptr = memremap_pages(&devmem->pagemap, numa_node_id());
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/test_hmm.c:1089:4: error: implicit declaration of function 'memunmap_pages' [-Werror,-Wimplicit-function-declaration]
> memunmap_pages(&devmem->pagemap);
>
> Add a dependency from CONFIG_TEST_HMM to ZONE_DEVICE, to disallow
> those broken configurations.
>
> Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index d9885fa37cc0..63667d62c9d8 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2262,6 +2262,7 @@ config TEST_MEMINIT
> config TEST_HMM
> tristate "Test HMM (Heterogeneous Memory Management)"
> depends on TRANSPARENT_HUGEPAGE
> + depends on ZONE_DEVICE
> select DEVICE_PRIVATE
> select HMM_MIRROR
> select MMU_NOTIFIER
>
--
~Randy
prev parent reply other threads:[~2020-05-08 18:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 14:40 [PATCH 1/2] HMM: test: fix CONFIG_DEVICE_PRIVATE dependencies Arnd Bergmann
2020-05-08 14:40 ` [PATCH 2/2] nouveau: fix dependencies for DEVICE_PRIVATE Arnd Bergmann
2020-05-08 15:00 ` Jason Gunthorpe
2020-05-08 15:05 ` Arnd Bergmann
2020-05-08 19:04 ` Jason Gunthorpe
2020-05-08 20:39 ` Arnd Bergmann
2020-05-08 18:05 ` Randy Dunlap
2020-05-11 13:52 ` Jason Gunthorpe
2020-05-08 17:00 ` [PATCH 1/2] HMM: test: fix CONFIG_DEVICE_PRIVATE dependencies Ralph Campbell
2020-05-08 18:05 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f55d763-9017-16e5-5765-75634c0c0c0c@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=changbin.du@intel.com \
--cc=jgg@mellanox.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rcampbell@nvidia.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).