From: Scott Wood <swood@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paul E . McKenney" <paulmck@linux.ibm.com>,
Joel Fernandes <joel@joelfernandes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH RT v3 3/5] sched: migrate_dis/enable: Use rt_invol_sleep
Date: Mon, 23 Sep 2019 11:59:23 -0500 [thread overview]
Message-ID: <404575720cf24765e66020f15ce75352f08a0ddb.camel@redhat.com> (raw)
In-Reply-To: <779eddcc937941e65659a11b1867c6623a2c8890.camel@redhat.com>
On Tue, 2019-09-17 at 09:06 -0500, Scott Wood wrote:
> On Tue, 2019-09-17 at 09:59 +0200, Sebastian Andrzej Siewior wrote:
> > On 2019-09-11 17:57:27 [+0100], Scott Wood wrote:
> > > diff --git a/kernel/cpu.c b/kernel/cpu.c
> > > index 885a195dfbe0..32c6175b63b6 100644
> > > --- a/kernel/cpu.c
> > > +++ b/kernel/cpu.c
> > > @@ -308,7 +308,9 @@ void pin_current_cpu(void)
> > > preempt_lazy_enable();
> > > preempt_enable();
> > >
> > > + rt_invol_sleep_inc();
> > > __read_rt_lock(cpuhp_pin);
> > > + rt_invol_sleep_dec();
> > >
> > > preempt_disable();
> > > preempt_lazy_disable();
> >
> > I understand the other one. But now looking at it, both end up in
> > rt_spin_lock_slowlock_locked() which would be the proper place to do
> > that annotation. Okay.
>
> FWIW, if my lazy migrate patchset is accepted, then there will be no users
> of __read_rt_lock() outside rwlock-rt.c and it'll be moot.
I missed the "both" -- which is the "other one" that ends up in
rt_spin_lock_slowlock_locked()? stop_one_cpu() doesn't...
-Scott
next prev parent reply other threads:[~2019-09-23 16:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 16:57 [PATCH RT v3 0/5] RCU fixes Scott Wood
2019-09-11 16:57 ` [PATCH RT v3 1/5] rcu: Acquire RCU lock when disabling BHs Scott Wood
2019-09-12 22:09 ` Joel Fernandes
2019-09-17 7:44 ` Sebastian Andrzej Siewior
2019-09-17 14:06 ` Scott Wood
2019-09-17 14:42 ` Sebastian Andrzej Siewior
2019-09-17 16:12 ` Scott Wood
2019-09-23 16:41 ` Sebastian Andrzej Siewior
2019-09-11 16:57 ` [PATCH RT v3 2/5] sched: Rename sleeping_lock to rt_invol_sleep Scott Wood
2019-09-17 7:52 ` Sebastian Andrzej Siewior
2019-09-11 16:57 ` [PATCH RT v3 3/5] sched: migrate_dis/enable: Use rt_invol_sleep Scott Wood
2019-09-17 7:59 ` Sebastian Andrzej Siewior
2019-09-17 14:06 ` Scott Wood
2019-09-23 16:59 ` Scott Wood [this message]
2019-09-23 17:52 ` Sebastian Andrzej Siewior
2019-09-24 11:21 ` Sebastian Andrzej Siewior
2019-09-24 13:53 ` Scott Wood
2019-09-24 15:25 ` Sebastian Andrzej Siewior
2019-09-24 15:47 ` Scott Wood
2019-09-24 16:05 ` Sebastian Andrzej Siewior
2019-09-24 16:35 ` Scott Wood
2019-10-04 16:45 ` Sebastian Andrzej Siewior
2019-09-11 16:57 ` [PATCH RT v3 4/5] rcu: Disable use_softirq on PREEMPT_RT Scott Wood
2019-09-12 21:38 ` Joel Fernandes
2019-09-12 22:19 ` Joel Fernandes
2019-09-17 9:31 ` Sebastian Andrzej Siewior
2019-09-17 14:08 ` Scott Wood
2019-09-11 16:57 ` [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT Scott Wood
2019-09-12 22:17 ` Joel Fernandes
2019-09-16 16:55 ` Scott Wood
2019-09-17 10:07 ` Sebastian Andrzej Siewior
2019-09-17 14:36 ` Scott Wood
2019-09-17 14:50 ` Sebastian Andrzej Siewior
2019-09-17 16:32 ` Scott Wood
2019-09-23 16:25 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404575720cf24765e66020f15ce75352f08a0ddb.camel@redhat.com \
--to=swood@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).