linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>, Elliott Mitchell <ehem+xen@m5p.com>
Cc: yazen.ghannam@amd.com, smita.koralahallichannabasappa@amd.com,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, xen-devel@lists.xenproject.org, rric@kernel.org,
	james.morse@arm.com, tony.luck@intel.com
Subject: Re: [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests"
Date: Wed, 13 Sep 2023 10:36:50 -0400	[thread overview]
Message-ID: <40d3399a-b260-4ffa-a503-40c61468a189@amd.com> (raw)
In-Reply-To: <20230908035911.GAZPqcD/EjfKZ0ISrZ@fat_crate.local>

On 9/7/23 11:59 PM, Borislav Petkov wrote:
> On Thu, Sep 07, 2023 at 08:08:00PM -0700, Elliott Mitchell wrote:
>> This reverts commit 767f4b620edadac579c9b8b6660761d4285fa6f9.
>>
>> There are at least 3 valid reasons why a VM may see MCE events/registers.
> 
> Hmm, so they all read like a bunch of handwaving to me, with those
> probable hypothetical "may" formulations.
> 
> How about we cut to the chase and you explain what exactly is the
> concrete issue you're encountering and trying to solve?

Also, please note that the EDAC modules don't handle MCE events
directly. They act on information passed from the MCE subsystem.

Furthermore, there are other EDAC modules that have the same !hypervisor
check, so why change only this one?

Thanks,
Yazen

  reply	other threads:[~2023-09-13 14:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 17:27 [PATCH] EDAC/mce_amd: Do not load edac_mce_amd module on guests Smita Koralahalli
2021-07-08 20:41 ` Yazen Ghannam
2021-07-23 18:18 ` Kim Phillips
2021-08-09 10:44 ` Borislav Petkov
2023-09-08  3:08 ` [PATCH] Revert "EDAC/mce_amd: Do not load edac_mce_amd module on guests" Elliott Mitchell
2023-09-08  3:59   ` Borislav Petkov
2023-09-13 14:36     ` Yazen Ghannam [this message]
2023-09-13 15:50       ` Luck, Tony
2023-09-13 16:21         ` Yazen Ghannam
2023-09-14 17:02     ` Elliott Mitchell
2023-09-15 11:56       ` Borislav Petkov
2023-09-21 21:18         ` Elliott Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40d3399a-b260-4ffa-a503-40c61468a189@amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=ehem+xen@m5p.com \
    --cc=james.morse@arm.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rric@kernel.org \
    --cc=smita.koralahallichannabasappa@amd.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).