From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD59C433F5 for ; Fri, 10 Dec 2021 21:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243151AbhLJVPS (ORCPT ); Fri, 10 Dec 2021 16:15:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235091AbhLJVPR (ORCPT ); Fri, 10 Dec 2021 16:15:17 -0500 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEB7EC0617A1 for ; Fri, 10 Dec 2021 13:11:41 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id 7so14869671oip.12 for ; Fri, 10 Dec 2021 13:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ddPQVV/tTQRudtCz1wmnWQGVTL4NkdF6U5BGESIoZIk=; b=K612s3Fuy5BAuqxT0vTsPBxg1trDU5wWijgKK96ec/bgtR04y7ecuOlsMuEghseFS+ pNtAQMrg4srdkdxkco1ivxHIMZMD2QBOn38kdMVJJehKKNWvuhsnBXvYQzQDc+81wCtC HJmaLOZu1uR46HiFcqALN/70qd3gyZ+e9kMUE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ddPQVV/tTQRudtCz1wmnWQGVTL4NkdF6U5BGESIoZIk=; b=iMM1kEdjrgivOvKRV36maRPWOiKnvVuRx8WxXfLanDWM+KJE9L8OWxd/RdRrK2+qp4 YomEbwZ8yznw/a9mTQzFDXP4fTUKB9MRLWvUseeai3qEZ/Cj9EgRVw9Z+hfIBMAtz1fz +h8sgagtpAntaXK6V+lqA1Q95mo2TjGjbG42cnfZ3OpVgqSXzqG0yBZQin2rzzgdBBvl PdU4Rmv+lZQUnyXE1pfx+0uKdEF2INc4TfZ0JuVJocP+xouFLT3D0CJUxKgHuVLEiVEQ 6VdC09+rlxsvOFPBgZJKI/Nairjzdb5NiqbfnhsKkUn162mmW3U0atF0XFrjnsHDDp32 uYkA== X-Gm-Message-State: AOAM53182gyaQGzwGDBvQxvCNH0UQ/WF2tnGXGYjiVKJz9HvR0KMDikN kuL6Oh3G0qc5LBdhuunhVghsCw== X-Google-Smtp-Source: ABdhPJyEtgLvk39lK6eB2KFY6omQ+KE/YL4n+zHawDHNL6h0rcXBzDJyAxY+VbrCCsBPr22P0QZYng== X-Received: by 2002:aca:1708:: with SMTP id j8mr14346312oii.62.1639170701316; Fri, 10 Dec 2021 13:11:41 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id o14sm702658ote.41.2021.12.10.13.11.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 13:11:41 -0800 (PST) Subject: Re: [RFC PATCH v2] Documentation: dev-tools: Add KTAP specification To: Jonathan Corbet , Kees Cook , David Gow Cc: Brendan Higgins , Tim.Bird@sony.com, shuah@kernel.org, rmr167@gmail.com, guillaume.tucker@collabora.com, dlatypov@google.com, kernelci@groups.io, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20211207190251.18426-1-davidgow@google.com> <202112071358.E8E6812D@keescook> <8c06e715-a83e-e8c6-74c3-836831b85cdf@linuxfoundation.org> <87mtl8qifu.fsf@meer.lwn.net> From: Shuah Khan Message-ID: <41323fe3-3f73-4681-7d75-2301f9982a25@linuxfoundation.org> Date: Fri, 10 Dec 2021 14:11:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87mtl8qifu.fsf@meer.lwn.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/21 2:05 PM, Jonathan Corbet wrote: > Shuah Khan writes: > >> On 12/7/21 3:02 PM, Kees Cook wrote: >>> On Tue, Dec 07, 2021 at 11:02:51AM -0800, David Gow wrote: >>>> From: Rae Moar >>>> >>>> It does not make any significant additions or changes other than those >>>> already in use in the kernel: additional features can be added as they >>>> become necessary and used. >>>> >>>> [1]: https://testanything.org/tap-version-13-specification.html >>>> >>>> Signed-off-by: Rae Moar >>>> Co-developed-by: David Gow >>>> Signed-off-by: David Gow >>> >>> I like it! Thank you so much for suffering through my earlier reviews. >>> :) >>> >>> The only concern I have is wonder what'll be needed to kselftest to >>> deal with indentation changes. As long as this can be implemented >>> without a subtest knowing it is a subtest, we're good. >>> >> >> A lot of this TAP output is in the wrappers - hopefully it will be okay. >> Fingers crossed. :) >> >>> Reviewed-by: Kees Cook >>> >> >> Looks good to me as well. Thanks for doing this work. >> >> Reviewed-by: Shuah Khan > > Would you like me to take this through the docs tree, or do you have > other plans for merging? > Please take this through docs. thanks, -- Shuah