linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Sriram Dash <sriram.dash@nxp.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	mathias.nyman@intel.com, gregkh@linuxfoundation.org,
	suresh.gupta@nxp.com, stern@rowland.harvard.edu,
	pku.leo@gmail.com
Subject: Re: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration
Date: Fri, 11 Nov 2016 21:31:09 +0100	[thread overview]
Message-ID: <4169621.fqZP0OpVbR@wuerfel> (raw)
In-Reply-To: <87fumzha30.fsf@linux.intel.com>

On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote:
> > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc)
> >  void dwc3_host_exit(struct dwc3 *dwc)
> >  {
> >       phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy",
> > -                       dev_name(&dwc->xhci->dev));
> > +                       dev_name(dwc->dev));
> >       phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy",
> > -                       dev_name(&dwc->xhci->dev));
> > +                       dev_name(dwc->dev));
> 
> this looks unrelated to $subject. Care to explain?

bus->sysdev is used for retrieving any information that comes from
the platform (DT or otherwise), and the phy lookup in has to be done
through sysdev as well because the platform cannot add it to
the child device it has no knowledge of.

When we set the sysdev to the parent, the phy lookup has to be
added to that device as well, rather than the child device.

	Arnd

  parent reply	other threads:[~2016-11-11 20:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10  8:19 [PATCH v3 0/6] inherit dma configuration from parent dev Sriram Dash
2016-11-10  8:19 ` [PATCH v3 1/6] usb: separate out sysdev pointer from usb_bus Sriram Dash
2016-11-10  8:19 ` [PATCH v3 2/6] usb: chipidea: use bus->sysdev for DMA configuration Sriram Dash
2016-11-10  8:19 ` [PATCH v3 3/6] usb: ehci: fsl: " Sriram Dash
2016-11-10  8:19 ` [PATCH v3 4/6] usb: xhci: " Sriram Dash
2016-11-10  8:20 ` [PATCH v3 5/6] usb: dwc3: " Sriram Dash
2016-11-10 11:02   ` Felipe Balbi
2016-11-11 10:42     ` Sriram Dash
2016-11-11 10:57       ` Felipe Balbi
2016-11-11 20:31     ` Arnd Bergmann [this message]
2016-11-14  1:51       ` Peter Chen
2016-11-14  4:46         ` Sriram Dash
2016-11-10 12:33   ` Baolin Wang
2016-11-11 10:43     ` Sriram Dash
2016-11-10  8:20 ` [PATCH v3 6/6] usb: dwc3: Do not set dma coherent mask Sriram Dash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4169621.fqZP0OpVbR@wuerfel \
    --to=arnd@arndb.de \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=pku.leo@gmail.com \
    --cc=sriram.dash@nxp.com \
    --cc=stern@rowland.harvard.edu \
    --cc=suresh.gupta@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).