From: Federico Vaga <federico.vaga@cern.ch>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Peter Korsgaard <peter@korsgaard.com>,
Peter Rosin <peda@axentia.se>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 0/5] i2c: ocores: improvements
Date: Thu, 14 Feb 2019 09:39:32 +0100 [thread overview]
Message-ID: <4284641.8ec35d25Ci@pcbe13614> (raw)
In-Reply-To: <20190214030733.GG24589@lunn.ch>
On Thursday, February 14, 2019 4:07:33 AM CET Andrew Lunn wrote:
> On Mon, Feb 11, 2019 at 05:49:08PM +0100, Federico Vaga wrote:
> > This patch set provides improvements to the i2c-ocore driver.
> >
> > [V5 -> V6]
> > - remove redundant code introduced in V5 (double read control register)
> >
> > [V4 -> V5]
> > - deterministic status of IEN bit in register "CONTROL" at the end of
> >
> > ocores_init()
> >
> > - more style fixes
> >
> > [V3 -> V4]
> > - add reviews-by/tested-by
> > - add comment to justify the formula in
> >
> > udelay((8 * 1000) / i2c->bus_clock_khz);
>
> Hi Federico
>
> It looks like all the reviewed-by: tags disappeared from v5.
>
> Can you add them back again, and then we can probably merge this
> patchset.
v7 is coming (@wolfram) with SPDX tag in the header file
> Thanks
> Andrew
prev parent reply other threads:[~2019-02-14 8:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 16:49 [PATCH v6 0/5] i2c: ocores: improvements Federico Vaga
2019-02-11 16:49 ` [PATCH v6 1/5] i2c: ocores: stop transfer on timeout Federico Vaga
2019-02-11 16:49 ` [PATCH v6 2/5] i2c: ocores: do not handle IRQ if IF is not set Federico Vaga
2019-02-11 16:49 ` [PATCH v6 3/5] i2c: ocores: add polling interface Federico Vaga
2019-02-11 16:49 ` [PATCH v6 4/5] i2c: ocores: add SPDX tag Federico Vaga
2019-02-11 16:54 ` Wolfram Sang
2019-02-12 8:10 ` Federico Vaga
2019-02-11 16:49 ` [PATCH v6 5/5] i2c: ocores: checkpatch fixes Federico Vaga
2019-02-14 3:07 ` [PATCH v6 0/5] i2c: ocores: improvements Andrew Lunn
2019-02-14 8:39 ` Federico Vaga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4284641.8ec35d25Ci@pcbe13614 \
--to=federico.vaga@cern.ch \
--cc=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).