From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F8DC433DB for ; Thu, 18 Mar 2021 01:56:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82B0B64E83 for ; Thu, 18 Mar 2021 01:56:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229702AbhCRB4C (ORCPT ); Wed, 17 Mar 2021 21:56:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbhCRBz3 (ORCPT ); Wed, 17 Mar 2021 21:55:29 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1234::107]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF26DC06174A; Wed, 17 Mar 2021 18:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=oMzWJkVczBjzFzxKEp2q/6qdsYB3/dcAkAMFScMmPws=; b=T4uHDSxbTJwEngklC0rXr16s7D mcgrxFUr7QdYI5sOiBjMlgy+CCw1qjKF8ziworeae7TXPHnukO6YRdia6tA93S9jLnxYCoQf/PFx9 sJFe2HGfCaM8XaHtaeZP1FSWGi/5TigixQiyeMdz4KelmcXnHyswalaDfCdicpneshJbIUwAnB02+ mtBIb8+sEdlvFvTZMapz7Joqd8AzYHmqsxeQBh3c48M1Yw80MqFSG0YDpuQVBbJVptFnuL8dFpAfo wSUx6/3ISGHAj9dVHUzLSurZSBP0p3f7csXNw4XuPowSXRNtNTu1Pt+CMMADQBLFQDGjCJnKuODWd ZwwvlaEA==; Received: from [2601:1c0:6280:3f0::9757] by merlin.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lMhrp-001hqj-4a; Thu, 18 Mar 2021 01:54:35 +0000 Subject: Re: [PATCH 1/1] leds: lgm: Improve Kconfig help To: Rahul Tanwar , Pavel Machek Cc: Arnd Bergmann , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Adam Borowski , "Rafael J. Wysocki" , John Crispin , Hauke Mehrtens , Cheol Yong Kim , Qiming Wu References: <8ae0456a08ef1a2491fd382b273ff7259e6fcbd0.1615969806.git.rtanwar@maxlinear.com> From: Randy Dunlap Message-ID: <42a0c810-4b6f-1853-60c9-e36a9dc6100a@infradead.org> Date: Wed, 17 Mar 2021 18:54:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, For the leds/blink/Kconfig file at least, something has changed all of the tabs to spaces. Keywords in Kconfig files should be indented with one tab, while help text should be indented with one tab + 2 spaces. On 3/17/21 3:04 AM, Rahul Tanwar wrote: > Remove unnecessary Kconfig symbol LEDS_BLINK > Improve Kconfig help text to make it more useful. > > Signed-off-by: Rahul Tanwar > --- > > diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig > index 6dedc58c47b3..2de2973fbc6b 100644 > --- a/drivers/leds/blink/Kconfig > +++ b/drivers/leds/blink/Kconfig > @@ -1,21 +1,19 @@ > -menuconfig LEDS_BLINK > - bool "LED Blink support" > - depends on LEDS_CLASS > - help > - This option enables blink support for the leds class. > - If unsure, say Y. > - > -if LEDS_BLINK > - > -config LEDS_BLINK_LGM > - tristate "LED support for Intel LGM SoC series" > +config LEDS_LGM > + tristate "LED support for LGM SoC series" > depends on GPIOLIB > depends on LEDS_CLASS > depends on MFD_SYSCON > depends on OF > help > - Parallel to serial conversion, which is also called SSO > controller, > - can drive external shift register for LED outputs. > - This enables LED support for Serial Shift Output controller(SSO). > + This option enables support for LEDs connected to GPIO lines on > + Lightning Mountain(LGM) SoC. These LEDs are driven by a Serial Mountain (LGM) > + Shift Output(SSO) controller. The driver supports hardware Output (SSO) > + blinking with a configurable LED update/blink frequency in two > + modes, 2/4/8/10 Hz in low speed mode and 50/100/200/250 KHz in > + high speed mode. The LEDs can be configured to be triggered by > + SW/CPU or by hardware. Say 'Y' here if you are working on LGM Please spell out "software". > + SoC based platform. > + > + To compile this driver as a module, choose M here: the > + module will be called leds-lgm-sso. > > -endif # LEDS_BLINK thanks. -- ~Randy