From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu
Cc: Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: venus: core: Fix runtime PM imbalance in venus_probe
Date: Tue, 23 Jun 2020 12:48:40 +0300 [thread overview]
Message-ID: <42a2a6cc-d873-1ec6-daaa-a4d5aebe619f@linaro.org> (raw)
In-Reply-To: <20200524052933.10529-1-dinghao.liu@zju.edu.cn>
Hi Dinghao,
Thanks for the patch!
On 5/24/20 8:29 AM, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even
> when it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced. For other error
> paths after this call, things are the same.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/media/platform/qcom/venus/core.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 194b10b98767..37db3b594dca 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -289,18 +289,24 @@ static int venus_probe(struct platform_device *pdev)
> goto err_core_deinit;
>
> ret = pm_runtime_put_sync(dev);
> - if (ret)
> - goto err_dev_unregister;
> + if (ret) {
> + v4l2_device_unregister(&core->v4l2_dev);
> + hfi_core_deinit(core, false);
> + venus_shutdown(core);
> + pm_runtime_set_suspended(dev);
> + pm_runtime_disable(dev);
> + hfi_destroy(core);
> + return ret;
Could you just reorder error labels below instead of releasing
everything here?
> + }
>
> return 0;
>
> -err_dev_unregister:
> - v4l2_device_unregister(&core->v4l2_dev);
> err_core_deinit:
> hfi_core_deinit(core, false);
> err_venus_shutdown:
> venus_shutdown(core);
> err_runtime_disable:
> + pm_runtime_put_noidle(dev);
> pm_runtime_set_suspended(dev);
> pm_runtime_disable(dev);
> hfi_destroy(core);
>
--
regards,
Stan
next prev parent reply other threads:[~2020-06-23 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 5:29 [PATCH] media: venus: core: Fix runtime PM imbalance in venus_probe Dinghao Liu
2020-06-23 9:48 ` Stanimir Varbanov [this message]
2020-06-24 6:18 ` dinghao.liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a2a6cc-d873-1ec6-daaa-a4d5aebe619f@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=kjlu@umn.edu \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).