From: Pierre Morel <pmorel@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, frankja@linux.ibm.com,
jasowang@redhat.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org,
thomas.lendacky@amd.com, david@gibson.dropbear.id.au,
linuxram@us.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com
Subject: Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature
Date: Mon, 6 Jul 2020 17:01:47 +0200 [thread overview]
Message-ID: <42f3733d-9f68-91b3-29f9-e88dd4495886@linux.ibm.com> (raw)
In-Reply-To: <20200706163340.2ce7a5f2.cohuck@redhat.com>
On 2020-07-06 16:33, Cornelia Huck wrote:
> On Mon, 6 Jul 2020 15:37:37 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> On 2020-07-02 15:03, Pierre Morel wrote:
>>>
>>>
>>> On 2020-06-29 18:05, Cornelia Huck wrote:
>>>> On Mon, 29 Jun 2020 11:57:14 -0400
>>>> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>>>
>>>>> On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote:
>>>>>> An architecture protecting the guest memory against unauthorized host
>>>>>> access may want to enforce VIRTIO I/O device protection through the
>>>>>> use of VIRTIO_F_IOMMU_PLATFORM.
>>>>>>
>>>>>> Let's give a chance to the architecture to accept or not devices
>>>>>> without VIRTIO_F_IOMMU_PLATFORM.
>>>>>>
>>>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>>>>> Acked-by: Jason Wang <jasowang@redhat.com>
>>>>>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>>>>> ---
>>>>>> arch/s390/mm/init.c | 6 ++++++
>>>>>> drivers/virtio/virtio.c | 22 ++++++++++++++++++++++
>>>>>> include/linux/virtio.h | 2 ++
>>>>>> 3 files changed, 30 insertions(+)
>>>>
>>>>>> @@ -179,6 +194,13 @@ int virtio_finalize_features(struct
>>>>>> virtio_device *dev)
>>>>>> if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1))
>>>>>> return 0;
>>>>>> + if (arch_needs_virtio_iommu_platform(dev) &&
>>>>>> + !virtio_has_feature(dev, VIRTIO_F_IOMMU_PLATFORM)) {
>>>>>> + dev_warn(&dev->dev,
>>>>>> + "virtio: device must provide VIRTIO_F_IOMMU_PLATFORM\n");
>>>>>> + return -ENODEV;
>>>>>> + }
>>>>>> +
>>>>>> virtio_add_status(dev, VIRTIO_CONFIG_S_FEATURES_OK);
>>>>>> status = dev->config->get_status(dev);
>>>>>> if (!(status & VIRTIO_CONFIG_S_FEATURES_OK)) {
>>>>>
>>>>> Well don't you need to check it *before* VIRTIO_F_VERSION_1, not after?
>>>>
>>>> But it's only available with VERSION_1 anyway, isn't it? So it probably
>>>> also needs to fail when this feature is needed if VERSION_1 has not been
>>>> negotiated, I think.
>>
>>
>> would be something like:
>>
>> - if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1))
>> - return 0;
>> + if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1)) {
>> + ret = arch_accept_virtio_features(dev);
>> + if (ret)
>> + dev_warn(&dev->dev,
>> + "virtio: device must provide
>> VIRTIO_F_VERSION_1\n");
>> + return ret;
>> + }
>
> That looks wrong; I think we want to validate in all cases. What about:
>
> ret = arch_accept_virtio_features(dev); // this can include checking for
> // older or newer features
> if (ret)
> // assume that the arch callback moaned already
> return ret;
>
> if (!virtio_has_feature(dev, VIRTIO_F_VERSION_1))
> return 0;
>
> // do the virtio-1 only FEATURES_OK dance
hum, you are right, I was too focused on keeping my simple
arch_accept_virtio_features() function unchanged.
It must be more general.
>
>>
>>
>> just a thought on the function name:
>> It becomes more general than just IOMMU_PLATFORM related.
>>
>> What do you think of:
>>
>> arch_accept_virtio_features()
>
> Or maybe arch_validate_virtio_features()?
OK validated.
Thanks,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2020-07-06 15:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 10:43 [PATCH v3 0/1] s390: virtio: let arch choose to accept devices without IOMMU feature Pierre Morel
2020-06-17 10:43 ` [PATCH v3 1/1] s390: virtio: let arch " Pierre Morel
2020-06-17 11:22 ` Heiko Carstens
2020-06-17 11:59 ` Pierre Morel
2020-06-17 13:36 ` Tom Lendacky
2020-06-17 14:12 ` Pierre Morel
2020-06-17 22:29 ` Halil Pasic
2020-06-19 9:20 ` Cornelia Huck
2020-06-19 12:02 ` Halil Pasic
2020-06-29 13:15 ` Pierre Morel
2020-06-29 13:14 ` Pierre Morel
2020-06-29 13:44 ` Cornelia Huck
2020-06-29 16:10 ` Pierre Morel
2020-06-29 13:21 ` Pierre Morel
2020-06-29 15:57 ` Michael S. Tsirkin
2020-06-29 16:05 ` Cornelia Huck
2020-07-02 13:03 ` Pierre Morel
2020-07-06 13:37 ` Pierre Morel
2020-07-06 14:33 ` Cornelia Huck
2020-07-06 15:01 ` Pierre Morel [this message]
2020-06-29 16:09 ` Pierre Morel
2020-06-29 16:09 ` Michael S. Tsirkin
2020-06-29 16:48 ` Pierre Morel
2020-06-29 21:18 ` Michael S. Tsirkin
2020-06-30 7:08 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f3733d-9f68-91b3-29f9-e88dd4495886@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).