From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751726AbWAKTYU (ORCPT ); Wed, 11 Jan 2006 14:24:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932198AbWAKTYU (ORCPT ); Wed, 11 Jan 2006 14:24:20 -0500 Received: from tornado.reub.net ([202.89.145.182]:31719 "EHLO tornado.reub.net") by vger.kernel.org with ESMTP id S1751726AbWAKTYT (ORCPT ); Wed, 11 Jan 2006 14:24:19 -0500 Message-ID: <43C55B31.5000201@reub.net> Date: Thu, 12 Jan 2006 08:23:29 +1300 From: Reuben Farrelly User-Agent: Thunderbird 1.6a1 (Windows/20060110) MIME-Version: 1.0 To: Jens Axboe CC: Andrew Morton , neilb@suse.de, mingo@elte.hu, linux-kernel@vger.kernel.org, Jeff Garzik , htejun@gmail.com Subject: Re: 2.6.15-mm2 References: <43C4947C.1040703@reub.net> <20060110213001.265a6153.akpm@osdl.org> <20060110213056.58f5e806.akpm@osdl.org> <43C4E2BE.6050800@reub.net> <20060111030529.0bc03e0a.akpm@osdl.org> <20060111111313.GD3389@suse.de> <43C4EEA4.3050502@reub.net> <20060111115616.GE3389@suse.de> <43C518BC.5090903@reub.net> <20060111145201.GS3389@suse.de> <20060111145504.GT3389@suse.de> In-Reply-To: <20060111145504.GT3389@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2006 3:55 a.m., Jens Axboe wrote: > On Wed, Jan 11 2006, Jens Axboe wrote: >> It's not too tricky, you just need to correct that function prototype. >> Could you do that? Would be nice to know _exactly_ which libata >> changeset caused this malfunction. But it does of course point at the >> barrier changes for scsi/libata... > > You can also try something quicker - use a newer kernel known to exhibit > the problem, and apply this patch on top of that: > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index 0302723..720ace4 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -436,6 +436,7 @@ void md_super_write(mddev_t *mddev, mdk_ > bio->bi_rw = rw; > > atomic_inc(&mddev->pending_writes); > +#if 0 > if (!test_bit(BarriersNotsupp, &rdev->flags)) { > struct bio *rbio; > rw |= (1< @@ -444,6 +445,7 @@ void md_super_write(mddev_t *mddev, mdk_ > rbio->bi_end_io = super_written_barrier; > submit_bio(rw, rbio); > } else > +#endif > submit_bio(rw, bio); > } ...and with that patch, I can now boot up 2.6.15-mm3 (repeated twice). So yes, looks like that's where the problem lies. Thanks Jens, Reuben