From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Ganapathi Bhat <gbhat@marvell.com>
Cc: Brian Norris <briannorris@chromium.org>,
amit karwar <amitkarwar@gmail.com>,
andreyknvl@google.com, "David S. Miller" <davem@davemloft.net>,
Dmitry Vyukov <dvyukov@google.com>,
Xinming Hu <huxinming820@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev@vger.kernel.org, Nishant Sarmukadam <nishants@marvell.com>,
syzbot+dc4127f950da51639216@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com,
syzbot <syzbot+373e6719b49912399d21@syzkaller.appspotmail.com>
Subject: Re: [PATCH] mwifiex: don't call del_timer_sync() on uninitialized timer
Date: Mon, 17 Aug 2020 22:06:07 +0900 [thread overview]
Message-ID: <45dd8b7c-584d-40dc-342a-6d894e0e68c8@i-love.sakura.ne.jp> (raw)
In-Reply-To: <CA+ASDXMHt2gq9Hy+iP_BYkWXsSreWdp3_bAfMkNcuqJ3K+-jbQ@mail.gmail.com>
Ganapathi, how do you want to fix this bug?
On 2020/07/29 3:45, Brian Norris wrote:
>> syzbot is reporting that del_timer_sync() is called from
>> mwifiex_usb_cleanup_tx_aggr() from mwifiex_unregister_dev() without
>> checking timer_setup() from mwifiex_usb_tx_init() was called [1].
>> Since mwifiex_usb_prepare_tx_aggr_skb() is calling del_timer() if
>> is_hold_timer_set == true, use the same condition for del_timer_sync().
>>
>> [1] https://syzkaller.appspot.com/bug?id=fdeef9cf7348be8b8ab5b847f2ed993aba8ea7b6
>>
>> Reported-by: syzbot <syzbot+373e6719b49912399d21@syzkaller.appspotmail.com>
>> Cc: Ganapathi Bhat <gbhat@marvell.com>
>> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>> ---
>> A patch from Ganapathi Bhat ( https://patchwork.kernel.org/patch/10990275/ ) is stalling
>> at https://lore.kernel.org/linux-usb/MN2PR18MB2637D7C742BC235FE38367F0A09C0@MN2PR18MB2637.namprd18.prod.outlook.com/ .
>> syzbot by now got this report for 10000 times. Do we want to go with this simple patch?
>
> Sorry, that stall is partly my fault, and partly Ganapathi's. It
> doesn't help that it took him 4 months to reply to my questions, so I
> completely lost even the tiny bit of context I had managed to build up
> in my head at initial review time... and so it's still buried in the
> dark corners of my inbox. (I think I'll go archive that now, because
> it really deserves a better sell than it had initially, if Ganapathi
> really wants to land it.)
next prev parent reply other threads:[~2020-08-17 13:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 14:26 INFO: trying to register non-static key in del_timer_sync (2) syzbot
2019-06-01 17:52 ` [EXT] " Ganapathi Bhat
2019-06-03 5:20 ` Dmitry Vyukov
2019-06-03 8:41 ` Ganapathi Bhat
2019-06-12 16:01 ` Ganapathi Bhat
2019-06-12 16:13 ` Andrey Konovalov
2019-06-12 16:59 ` syzbot
2019-08-13 13:36 ` [EXT] " Andrey Konovalov
2019-08-13 13:58 ` Kalle Valo
2019-08-14 14:08 ` Ganapathi Bhat
2019-10-01 16:40 ` Andrey Konovalov
2019-10-02 14:28 ` Ganapathi Bhat
2020-07-28 1:44 ` [PATCH] mwifiex: don't call del_timer_sync() on uninitialized timer Tetsuo Handa
2020-07-28 17:29 ` Andy Shevchenko
2020-07-28 18:45 ` Brian Norris
2020-08-17 13:06 ` Tetsuo Handa [this message]
2020-08-21 8:27 ` [PATCH v2] " Tetsuo Handa
2020-08-24 18:52 ` Brian Norris
2020-08-27 4:50 ` [EXT] " Ganapathi Bhat
2020-08-27 10:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45dd8b7c-584d-40dc-342a-6d894e0e68c8@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=amitkarwar@gmail.com \
--cc=andreyknvl@google.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=syzbot+373e6719b49912399d21@syzkaller.appspotmail.com \
--cc=syzbot+dc4127f950da51639216@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).