From: Icenowy Zheng <icenowy@aosc.io>
To: linux-arm-kernel@lists.infradead.org,
Maxime Ripard <maxime.ripard@bootlin.com>,
Mesih Kilinc <mesihkilinc@gmail.com>
Cc: devicetree@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Julian Calaby <julian.calaby@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v2 03/14] ARM: sunxi: add Allwinner ARMv5 SoCs
Date: Wed, 21 Nov 2018 07:36:38 +0800 [thread overview]
Message-ID: <464C921F-1AA7-4475-9085-25D03D21AFE2@aosc.io> (raw)
In-Reply-To: <20181120084245.bnjdaf647e6tdlku@flea>
于 2018年11月20日 GMT+08:00 下午4:42:45, Maxime Ripard <maxime.ripard@bootlin.com> 写到:
>On Sun, Nov 18, 2018 at 05:17:02PM +0300, Mesih Kilinc wrote:
>> Add option for Allwinner ARMv5 SoCs and SoC F1C100s (which has a die
>> used for many new F-series products, including F1C100A, F1C100s,
>F1C200s,
>> F1C500, F1C600).
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> Signed-off-by: Mesih Kilinc <mesihkilinc@gmail.com>
>> ---
>> arch/arm/mach-sunxi/Kconfig | 14 +++++++++++++-
>> arch/arm/mach-sunxi/Makefile | 1 +
>> arch/arm/mach-sunxi/sunxi_v5.c | 22 ++++++++++++++++++++++
>> 3 files changed, 36 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm/mach-sunxi/sunxi_v5.c
>>
>> diff --git a/arch/arm/mach-sunxi/Kconfig
>b/arch/arm/mach-sunxi/Kconfig
>> index 5db17ec..066644c 100644
>> --- a/arch/arm/mach-sunxi/Kconfig
>> +++ b/arch/arm/mach-sunxi/Kconfig
>> @@ -1,6 +1,6 @@
>> menuconfig ARCH_SUNXI
>> bool "Allwinner SoCs"
>> - depends on ARCH_MULTI_V7
>> + depends on ARCH_MULTI_V5 || ARCH_MULTI_V7
>> select ARCH_HAS_RESET_CONTROLLER
>> select CLKSRC_MMIO
>> select GENERIC_IRQ_CHIP
>> @@ -64,4 +64,16 @@ config ARCH_SUNXI_MC_SMP
>>
>> endif
>>
>> +if ARCH_MULTI_V5
>> +
>> +config ARCH_SUNXI_V5
>> + bool
>> + select SUN4I_TIMER
>
>If SUN4I_TIMER is needed both by the armv5 and armv7 cores, why did we
>need to move it out of ARCH_SUNXI?
>
>> +config MACH_SUNIV
>> + bool "Allwinner new F-series (suniv) SoCs support"
>
>I would drop the "new" here.
Sorry, but old F-series SoCs are not suniv. They are sunii or sun3i.
>
>> +++ b/arch/arm/mach-sunxi/sunxi_v5.c
>> @@ -0,0 +1,22 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Device Tree support for Allwinner F series SoCs
>> + *
>> + * Copyright (C) 2017 Icenowy Zheng <icenowy@aosc.io>
>> + * Copyright (C) 2018 Mesih Kilinc <mesihkilinc@gmail.com>
>> + *
>> + * This file is licensed under the terms of the GNU General Public
>> + * License version 2. This program is licensed "as is" without any
>> + * warranty of any kind, whether express or implied.
>> + */
>> +
>> +#include <asm/mach/arch.h>
>> +
>> +static const char * const suniv_board_dt_compat[] = {
>> + "allwinner,suniv-f1c100s",
>> + NULL,
>> +};
>> +
>> +DT_MACHINE_START(SUNXI_DT, "Allwinner suniv Family")
>> + .dt_compat = suniv_board_dt_compat,
>> +MACHINE_END
>
>Do we really need a separate file for that?
>
>Maxime
next prev parent reply other threads:[~2018-11-20 23:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 14:16 [RFC PATCH v2 00/14] initial support for "suniv" Allwinner new ARM9 SoC Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 01/14] ARM: add CONFIG_ARCH_SUNXI_V7 for differentiate ARMv5/v7 Allwinner SoCs Mesih Kilinc
2018-11-20 8:40 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 02/14] dt-bindings: arm: Add new Allwinner ARMv5 F1C100s SoC Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 03/14] ARM: sunxi: add Allwinner ARMv5 SoCs Mesih Kilinc
2018-11-20 8:42 ` Maxime Ripard
2018-11-20 23:36 ` Icenowy Zheng [this message]
2018-11-18 14:17 ` [RFC PATCH v2 04/14] dt-bindings: interrupt-controller: Add suniv interrupt-controller Mesih Kilinc
2018-11-20 8:44 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 05/14] irqchip/sun4i: add support for suniv interrupt controller Mesih Kilinc
2018-11-20 8:48 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 06/14] dt-bindings: timer: Add Allwinner suniv timer Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 07/14] clocksource: sun4i: add a compatible for suniv Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 08/14] clocksource/drivers/sun4i: register as sched_clock on suniv Mesih Kilinc
2018-11-20 8:49 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 09/14] dt-bindings: pinctrl: Add Allwinner suniv F1C100s pinctrl Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 10/14] pinctrl: sunxi: add support for suniv F1C100s (newer F-series SoCs) Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 11/14] dt-bindings: clock: Add Allwinner suniv F1C100s CCU Mesih Kilinc
2018-11-20 8:52 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 12/14] clk: sunxi-ng: add support for suniv F1C100s SoC Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 13/14] ARM: dts: suniv: add initial DTSI file for F1C100s Mesih Kilinc
2018-11-20 8:55 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 14/14] ARM: suniv: f1c100s: add device tree for Lichee Pi Nano Mesih Kilinc
2018-11-20 8:56 ` [RFC PATCH v2 00/14] initial support for "suniv" Allwinner new ARM9 SoC Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464C921F-1AA7-4475-9085-25D03D21AFE2@aosc.io \
--to=icenowy@aosc.io \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=julian.calaby@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mesihkilinc@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).