From: Reinette Chatre <reinette.chatre@intel.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/resctrl: Fix potential memory leak
Date: Thu, 19 Dec 2019 21:46:40 -0800 [thread overview]
Message-ID: <47f3789b-65cb-172e-ae56-ac8477613a5c@intel.com> (raw)
In-Reply-To: <CALvZod7zi+t9A=4_L-iiD3JhFpGU0Jt-=Q1_ee=7=7KAUMykVA@mail.gmail.com>
Hi Shakeel,
On 12/19/2019 5:54 PM, Shakeel Butt wrote:
> On Thu, Dec 19, 2019 at 3:27 PM Reinette Chatre
> <reinette.chatre@intel.com> wrote:
>> On 12/19/2019 2:38 PM, Shakeel Butt wrote:
>>> The set_cache_qos_cfg() is leaking memory when the given level is not
>>> RDT_RESOURCE_L3 or RDT_RESOURCE_L2. Fix that.
>>
>> I think it would be valuable to those considering whether they need to
>> backport to know that RDT_RESOURCE_L3 and RDT_RESOURCE_L2 are currently
>> the only possible levels with which this function is called. It is thus
>> not currently possible for this leak to occur. Indeed a valuable safety
>> to add in case this code may change in the future. Thank you very much.
>>
>
> Do you want me to add that info the commit and resend the v2 of the patch?
>
Yes please.
Thank you very much
Reinette
prev parent reply other threads:[~2019-12-20 5:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 22:38 [PATCH] x86/resctrl: Fix potential memory leak Shakeel Butt
2019-12-19 23:02 ` Fenghua Yu
2019-12-19 23:26 ` Reinette Chatre
2019-12-20 1:54 ` Shakeel Butt
2019-12-20 5:46 ` Reinette Chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f3789b-65cb-172e-ae56-ac8477613a5c@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).