From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: tiwai@suse.com, "Jaroslav Kysela" <perex@perex.cz>,
"Kailang Yang" <kailang@realtek.com>,
"Hui Wang" <hui.wang@canonical.com>,
"Jian-Hong Pan" <jian-hong@endlessm.com>,
"Tomas Espeleta" <tomas.espeleta@gmail.com>,
"Thomas Hebb" <tommyhebb@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] ALSA: hda/realtek: Add mute LED and micmute LED support for HP systems
Date: Wed, 17 Jun 2020 23:25:10 +0800 [thread overview]
Message-ID: <486196C0-891B-47BA-8A5A-A9B65D27E7E5@canonical.com> (raw)
In-Reply-To: <s5hbllhzz2m.wl-tiwai@suse.de>
> On Jun 17, 2020, at 19:55, Takashi Iwai <tiwai@suse.de> wrote:
>
> On Wed, 17 Jun 2020 12:29:02 +0200,
> Kai-Heng Feng wrote:
>>
>> There are two more HP systems control mute LED from HDA codec and need
>> to expose micmute led class so SoF can control micmute LED.
>>
>> Add quirks to support them.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> I guess this can be applied independently from the patch#1?
> If so, I'll queue this for for-linus branch.
Yes please. Thanks!
Kai-Heng
>
>
> thanks,
>
> Takashi
>
>
>> ---
>> v3:
>> - No change.
>> v2:
>> - Wording.
>>
>> sound/pci/hda/patch_realtek.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 0587d1e96b19..cd1a3619806a 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -7473,6 +7473,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>> SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>> SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>> SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>> + SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
>> + SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
>> SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_LED),
>> SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
>> SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2020-06-17 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 10:29 [PATCH v3 1/2] ALSA: hda/realtek: Add COEF controlled micmute LED support Kai-Heng Feng
2020-06-17 10:29 ` [PATCH v3 2/2] ALSA: hda/realtek: Add mute LED and micmute LED support for HP systems Kai-Heng Feng
2020-06-17 11:55 ` Takashi Iwai
2020-06-17 15:25 ` Kai-Heng Feng [this message]
2020-06-17 15:44 ` Takashi Iwai
2020-06-17 11:55 ` [PATCH v3 1/2] ALSA: hda/realtek: Add COEF controlled micmute LED support Takashi Iwai
2020-06-17 15:24 ` Kai-Heng Feng
2020-06-17 15:50 ` Takashi Iwai
2020-06-18 5:15 ` Kai-Heng Feng
2020-06-18 7:32 ` Takashi Iwai
2020-06-18 10:16 ` Kai-Heng Feng
2020-06-18 11:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486196C0-891B-47BA-8A5A-A9B65D27E7E5@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=hui.wang@canonical.com \
--cc=jian-hong@endlessm.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=tomas.espeleta@gmail.com \
--cc=tommyhebb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).