From: Chao Yu <chao@kernel.org>
To: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com
Cc: Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH v4 2/2] f2fs: introduce periodic iostat io latency traces
Date: Fri, 20 Aug 2021 18:50:54 +0800 [thread overview]
Message-ID: <48725f58-1a48-73f3-80cf-a0c5efc3b470@kernel.org> (raw)
In-Reply-To: <20210820035229.216975-2-daeho43@gmail.com>
On 2021/8/20 11:52, Daeho Jeong wrote:
> +void iostat_update_and_unbind_ctx(struct bio *bio, int rw)
> +{
> + struct bio_iostat_ctx *iostat_ctx = bio->bi_private;
> + int sync_type = bio->bi_opf & REQ_SYNC ? 0 : 1;
int sync_type = bio->bi_opf & REQ_SYNC ? 1 : 0;
Right?
> int f2fs_init_iostat(struct f2fs_sb_info *sbi)
> {
> /* init iostat info */
> spin_lock_init(&sbi->iostat_lock);
> + spin_lock_init(&sbi->iostat_lat_lock);
> sbi->iostat_enable = false;
> sbi->iostat_period_ms = DEFAULT_IOSTAT_PERIOD_MS;
> + sbi->iostat_io_lat = f2fs_kzalloc(sbi, sizeof(struct iostat_lat_info),
> + GFP_KERNEL);
> + if (!sbi->iostat_io_lat)
> + return -ENOMEM;
What do you think of just embedding iostat_io_lat structure into f2fs_sb_info
structure? it's minor thing though.
Thanks,
next prev parent reply other threads:[~2021-08-20 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 3:52 [PATCH v4 1/2] f2fs: separate out iostat feature Daeho Jeong
2021-08-20 3:52 ` [PATCH v4 2/2] f2fs: introduce periodic iostat io latency traces Daeho Jeong
2021-08-20 10:50 ` Chao Yu [this message]
2021-08-20 15:23 ` [f2fs-dev] " Daeho Jeong
2021-08-20 21:41 ` Chao Yu
2021-08-20 21:52 ` Chao Yu
2021-08-20 10:35 ` [f2fs-dev] [PATCH v4 1/2] f2fs: separate out iostat feature Chao Yu
2021-08-23 17:16 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48725f58-1a48-73f3-80cf-a0c5efc3b470@kernel.org \
--to=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).