From: "Leonard, Niall" <Niall.Leonard@ncr.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] gpio: mmio: Use new flag BGPIOF_NO_INPUT
Date: Tue, 31 Jan 2023 10:23:37 +0000 [thread overview]
Message-ID: <494ca890-098d-1ba8-321b-b6378546835d@ncr.com> (raw)
In-Reply-To: <3c5b6ae1-387f-143c-691f-92b96fe78270@linaro.org>
On 29/01/2023 16:01, Krzysztof Kozlowski wrote:
> *External Message* - Use caution before opening links or attachments
>
> On 26/01/2023 11:17, Niall Leonard via B4 Submission Endpoint wrote:
>> From: Niall Leonard <nl250060@ncr.com>
>>
>> Use the existing shadow data register 'bgpio_data' to allow
>> the last written value to be returned by the read operation
>> when BGPIOF_NO_INPUT flag is set.
>>
>
> (...)
>
>> if (gc->set == bgpio_set_set &&
>> !(flags & BGPIOF_UNREADABLE_REG_SET))
>> gc->bgpio_data = gc->read_reg(gc->reg_set);
>> @@ -711,6 +723,9 @@ static struct bgpio_pdata *bgpio_parse_dt(struct platform_device *pdev,
>> if (of_property_read_bool(pdev->dev.of_node, "no-output"))
>> *flags |= BGPIOF_NO_OUTPUT;
>>
>> + if (of_property_read_bool(pdev->dev.of_node, "no-input"))
>
> As pointed, this brings undocumented property to two other bindings.
> This needs to be fixed.
>
> Best regards,
> Krzysztof
>
Thanks for reviewing.
I will update the other 2 bindings in the next version.
Regards,
Niall Leonard
prev parent reply other threads:[~2023-01-31 10:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:17 [PATCH 0/3] Introduce new optional property to mark port as write only Niall Leonard via B4 Submission Endpoint
2023-01-26 10:17 ` [PATCH 1/3] gpio: dt-bindings: add new property to wd,mbl-gpio bindings Niall Leonard via B4 Submission Endpoint
2023-01-26 12:28 ` Krzysztof Kozlowski
2023-01-27 11:39 ` Leonard, Niall
2023-01-29 15:59 ` Krzysztof Kozlowski
2023-01-30 13:20 ` Leonard, Niall
2023-01-30 18:37 ` Rob Herring
2023-01-31 10:25 ` Leonard, Niall
2023-01-27 12:57 ` Linus Walleij
2023-01-26 10:17 ` [PATCH 2/3] gpio: Add new flag BGPIOF_NO_INPUT Niall Leonard via B4 Submission Endpoint
2023-01-27 12:54 ` Linus Walleij
2023-01-31 10:22 ` Leonard, Niall
2023-01-26 10:17 ` [PATCH 3/3] gpio: mmio: Use " Niall Leonard via B4 Submission Endpoint
2023-01-27 12:53 ` Linus Walleij
2023-01-29 16:01 ` Krzysztof Kozlowski
2023-01-31 10:23 ` Leonard, Niall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494ca890-098d-1ba8-321b-b6378546835d@ncr.com \
--to=niall.leonard@ncr.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).