From: Randy Dunlap <rdunlap@xenotime.net>
To: Dan Carpenter <error27@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: bug list: putting too much data on the stack
Date: Thu, 11 Feb 2010 09:01:35 -0800 [thread overview]
Message-ID: <4B7437EF.2050001@xenotime.net> (raw)
In-Reply-To: <20100211085120.GF14210@bicker>
On 02/11/10 00:51, Dan Carpenter wrote:
> This is a list of functions that put a lot of data (500 bytes) on the stack.
> I don't know if 500 is reasonable, but I've seen people complaining about
> smaller amounts.
>
> The list was generated by:
> make C=1 CHECK="/path/to/smatch -p=kernel" modules bzImage | tee warns.txt
> grep "bytes on stack" warns.txt
>
> regards,
> dan carpenter
>
> Previous bug lists:
> * Assigning negative values to unsigned variables
> http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01222.html
>
> * Doing dma on the stack
> http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01231.html
>
> * Dereferencing variables before verifying they are not null
> http://lkml.indiana.edu/hypermail/linux/kernel/1001.3/01980.html
>
...
> drivers/media/dvb/frontends/dib3000mc.c +816 dib3000mc_i2c_enumeration(2) warn: 'st' puts 1416 bytes on stack
> drivers/media/dvb/frontends/dib7000p.c +1326 dib7000p_i2c_enumeration(2) warn: 'st' puts 1468 bytes on stack
I posted patches for these a few days ago. Andrew put them into mmotm.
linux-media hasn't responded to them yet.
http://patchwork.kernel.org/patch/77892/
http://patchwork.kernel.org/patch/77891/
--
~Randy
prev parent reply other threads:[~2010-02-11 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 8:51 bug list: putting too much data on the stack Dan Carpenter
2010-02-11 10:03 ` Miklos Szeredi
2010-02-11 17:01 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7437EF.2050001@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).