linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Marc Kleine-Budde <mkl@blackshift.org>,
	linux-kernel@vger.kernel.org, Imre Kaloz <kaloz@openwrt.org>,
	linux-arm-kernel@lists.infradead.org,
	Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [PATCH 1/2] ARM: ixp4xx: fix compilation, add gpiolib support
Date: Thu, 09 Feb 2012 10:08:09 +0100	[thread overview]
Message-ID: <4F338CF9.6050803@pengutronix.de> (raw)
In-Reply-To: <20275.35898.120590.54388@pilspetsen.it.uu.se>

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On 02/09/2012 10:04 AM, Mikael Pettersson wrote:
> Marc Kleine-Budde writes:
>  > From: Imre Kaloz <kaloz@openwrt.org>
>  > 
>  > The problem was introduced with commit:
>  > "eb9ae7f gpio: fix build error in include/asm-generic/gpio.h"
>  > 
>  > This patch adds gpiolib support for the IXP4xx platform, which fixes the
>  > compilation of several ixp4xx platforms, e.g.:
>  > 
>  > In file included from arch/arm/mach-ixp4xx/include/mach/gpio.h:72,
>  >                  from /home/frogger/projects/server/linux/arch/arm/include/asm/gpio.h:9,
>  >                  from include/linux/gpio.h:30,
>  >                  from arch/arm/mach-ixp4xx/nslu2-setup.c:19:
>  > include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep':
>  > include/asm-generic/gpio.h:218: error: implicit declaration of function '__gpio_get_value'
>  > include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep':
>  > include/asm-generic/gpio.h:224: error: implicit declaration of function '__gpio_set_value'
> 
> This fix is needed for 3.2 too, right?  I got the same errors when
> updating my (out-of-tree) ixp4xx/ds101 platform support to the 3.2 kernel
> a few days ago.

Yes, it's needed for 3.2, too. I'll put stable on Cc.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2012-02-09  9:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08 19:24 [PATCH 0/2] ARM: ixp4xx: fix compilation and oops Marc Kleine-Budde
2012-02-08 19:24 ` [PATCH 1/2] ARM: ixp4xx: fix compilation, add gpiolib support Marc Kleine-Budde
2012-02-09  9:04   ` Mikael Pettersson
2012-02-09  9:08     ` Marc Kleine-Budde [this message]
2012-02-09 10:57     ` Arnaud Patard
2012-02-09 13:37       ` Marc Kleine-Budde
2012-02-09  9:11   ` Russell King - ARM Linux
2012-02-09 13:40     ` Marc Kleine-Budde
2012-02-09 14:33       ` Russell King - ARM Linux
2012-04-12  5:25   ` Richard Cochran
2012-04-24  6:10     ` Jonathan Nieder
2012-02-08 19:24 ` [PATCH 2/2] mtd: ixp4xx: oops in ixp4xx_flash_probe Marc Kleine-Budde
2012-02-09 12:11   ` Artem Bityutskiy
2012-02-09 13:15     ` Marc Kleine-Budde
2012-04-07 15:18 ` [PATCH 0/2] ARM: ixp4xx: fix compilation and oops Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F338CF9.6050803@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=kaloz@openwrt.org \
    --cc=khc@pm.waw.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=mkl@blackshift.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).