From: Michal Simek <michal.simek@xilinx.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
Michal Simek <michal.simek@xilinx.com>
Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] mmc: sdhci-of-arasan: constify sdhci_pltfm_data and sdhci_ops structures
Date: Mon, 7 Aug 2017 14:50:38 +0200 [thread overview]
Message-ID: <4a087f6a-a51c-2add-402f-2d377457482e@xilinx.com> (raw)
In-Reply-To: <1502099444-10473-5-git-send-email-Julia.Lawall@lip6.fr>
On 7.8.2017 11:50, Julia Lawall wrote:
> The sdhci_pltfm_data structure is only passed as the second argument
> of sdhci_pltfm_init, which is const, while the sdhci_ops structure
> is only stored in the ops field of a sdhci_pltfm_data structure,
> which is also const. Thus both kinds of structures can be const as
> well.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 528a5d2..0720ea7 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -262,7 +262,7 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc,
> return -EINVAL;
> }
>
> -static struct sdhci_ops sdhci_arasan_ops = {
> +static const struct sdhci_ops sdhci_arasan_ops = {
> .set_clock = sdhci_arasan_set_clock,
> .get_max_clock = sdhci_pltfm_clk_get_max_clock,
> .get_timeout_clock = sdhci_pltfm_clk_get_max_clock,
> @@ -271,7 +271,7 @@ static int sdhci_arasan_voltage_switch(struct mmc_host *mmc,
> .set_uhs_signaling = sdhci_set_uhs_signaling,
> };
>
> -static struct sdhci_pltfm_data sdhci_arasan_pdata = {
> +static const struct sdhci_pltfm_data sdhci_arasan_pdata = {
> .ops = &sdhci_arasan_ops,
> .quirks = SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
> .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN |
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
next prev parent reply other threads:[~2017-08-07 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 9:50 [PATCH 0/5] constify sdhci_pltfm_data and sdhci_ops structures Julia Lawall
2017-08-07 9:50 ` [PATCH 1/5] drivers/mmc/host: constify sdhci_pltfm_data structures Julia Lawall
2017-08-07 9:50 ` [PATCH 2/5] mmc: sdhci-bcm-kona: constify sdhci_pltfm_data and sdhci_ops structures Julia Lawall
2017-08-07 9:50 ` [PATCH 3/5] mmc: sdhci-sirf: " Julia Lawall
2017-08-07 9:50 ` [PATCH 4/5] mmc: sdhci-of-arasan: " Julia Lawall
2017-08-07 12:50 ` Michal Simek [this message]
2017-08-07 9:50 ` [PATCH 5/5] mmc: sdhci-brcmstb: constify sdhci_pltfm_data structures Julia Lawall
2017-08-08 10:38 ` [PATCH 0/5] constify sdhci_pltfm_data and sdhci_ops structures Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a087f6a-a51c-2add-402f-2d377457482e@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=Julia.Lawall@lip6.fr \
--cc=adrian.hunter@intel.com \
--cc=bhumirks@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).