From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Linuxarm <linuxarm@huawei.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
"Will Deacon" <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: perf segmentation fault from NULL dereference
Date: Tue, 2 Oct 2018 11:41:36 +0100 [thread overview]
Message-ID: <4ac88076-60fa-4509-7fa0-2f99d73174d2@huawei.com> (raw)
In-Reply-To: <20180927160210.GF6916@krava>
>> I am suspicious that this is a real issue, as this patch has been in
>> mainline for some time...
>>
>> This simple change fixes the issue me:
>> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
>> index 91e6d9c..f4fd826 100644
>> --- a/tools/perf/util/header.c
>> +++ b/tools/perf/util/header.c
>> @@ -3576,7 +3576,7 @@ int perf_event__process_feature(struct perf_tool
>> *tool,
>> int max, err;
>> u16 type;
>>
>> - if (!evsel->own_cpus)
>> + if (!evsel->own_cpus || !(evsel->attr.read_format & PERF_FORMAT_ID)) //
>> roundabout check for !evsel->id
>> return 0;
>>
>> ev = cpu_map_data__alloc(evsel->own_cpus, &size, &type, &max);
>>
>> It turns out that evsel->id is NULL on a call to
>> perf_event__process_feature(), which upsets this code:
>>
>> ev->header.type = PERF_RECORD_EVENT_UPDATE;
>> ev->header.size = (u16)size;
>> ev->type = PERF_EVENT_UPDATE__CPUS;
>> ev->id = evsel->id[0];
>>
>> Please me let me know if a valid issue so we can get a fix in.
>
> yea, I can see how we can get here with event having
> its own CPUs, and we allocate the id array later at
> the time we map the event
>
> I wonder instead of skipping on this feature, we should
> allocate the id array, like below
>
> I did not test that.. need to find the server having event
> with its own cpus.. also need to make sure evsel->cpus is
> the way to go in here
>
Thanks for the fix, but I got this:
root@localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
Couldn't synthesize evsel cpus.
root@localhost:~#
> thanks,
> jirka
>
>
> ---
> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 1ec1d9bc2d63..fb2a0dab3978 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -29,6 +29,7 @@
> #include "symbol.h"
> #include "debug.h"
> #include "cpumap.h"
> +#include "thread_map.h"
> #include "pmu.h"
> #include "vdso.h"
> #include "strbuf.h"
> @@ -3579,6 +3580,11 @@ perf_event__synthesize_event_update_cpus(struct perf_tool *tool,
> if (!evsel->own_cpus)
> return 0;
>
> + if (!evsel->id ||
for my test, evsel->id is NULL
> + perf_evsel__alloc_id(evsel, cpu_map__nr(evsel->cpus),
> + thread_map__nr(evsel->threads)))
and then this function is not called as we return immediately. So did
you really want this:
if (!evsel->id && perf_evsel__alloc_id(...))
return -ENOMEM;
This looks to work:
root@localhost:~# ./perf_debug_ record -e armv8_pmuv3_0/br_mis_pred/ sleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.001 MB perf.data (7 samples) ]
root@localhost:~# ./perf_debug_ report
# To display the perf.data header info, please use
--header/--header-only option
#
#
# Total Lost Samples: 0
#
# Samples: 7 of event 'armv8_pmuv3_0/br_mis_pred/'
# Event count (approx.): 8260
#
# Overhead Command Shared Object Symbol
# ........ ....... ................. ......................
#
78.28% sleep libc-2.23.so [.] 0x00000000000faef0
20.53% sleep [kernel.kallsyms] [k] vmacache_find
1.09% sleep [kernel.kallsyms] [k] find_vma
0.10% perf_de [kernel.kallsyms] [k] perf_event_exec
#
# (Cannot load tips.txt file, please install perf!)
#
root@localhost:~#
> + return -ENOMEM;
> +
> ev = cpu_map_data__alloc(evsel->own_cpus, &size, &type, &max);
> if (!ev)
> return -ENOMEM;
>
> .
>
Thanks,
John
next prev parent reply other threads:[~2018-10-02 10:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 15:53 perf segmentation fault from NULL dereference John Garry
2018-09-27 3:00 ` Andi Kleen
2018-10-02 10:20 ` John Garry
2018-09-27 16:02 ` Jiri Olsa
2018-10-02 10:41 ` John Garry [this message]
2018-10-02 11:16 ` Jiri Olsa
2018-10-03 11:36 ` [PATCH] perf tools: Allocate id array in perf_event__synthesize_event_update_cpus Jiri Olsa
2018-10-03 14:08 ` John Garry
2018-10-03 14:16 ` Jiri Olsa
2018-10-03 21:20 ` [PATCH] perf tools: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus Jiri Olsa
2018-10-04 9:20 ` John Garry
2018-10-09 10:00 ` Jiri Olsa
2018-10-12 13:25 ` John Garry
2018-10-15 19:15 ` Arnaldo Carvalho de Melo
2018-10-16 9:10 ` John Garry
2018-10-16 10:47 ` Jiri Olsa
2018-10-18 6:18 ` [tip:perf/urgent] perf evsel: " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ac88076-60fa-4509-7fa0-2f99d73174d2@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).