From: Rafael David Tinoco <rafael.tinoco@linaro.org>
To: shuah@kernel.org
Cc: Rafael David Tinoco <rafael.tinoco@linaro.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@kernel.org,
mathieu.desnoyers@efficios.com
Subject: Re: [PATCH v5] selftests: membarrier: re-organize test
Date: Sun, 18 Nov 2018 18:44:50 -0200 [thread overview]
Message-ID: <4b31ee44-6463-6f6b-ca43-f03af8b06e35@linaro.org> (raw)
In-Reply-To: <20181109154911.24464-1-rafael.tinoco@linaro.org>
>> Why do we need to add new routines for these conditions. Why can't handle these strings in array. For example you can define an array of strings for passed unexpectedly etc. and the pass the string to appropriate ksft_* interface instead of adding of these routines. Also it is hard to review the code this way.
I was able to fit all the logic in the 80 char limit and, still, give a
notion what was being called on each condition (instead of using an
array number or equivalent). Considering this is not the core code, and
the this has been already accepted and reviewed in LTP project, would
you mind accepting it so both can be maintained together ? It is much
better than the existing one, anyway...
Note: I have removed the part where we test for older return codes,
since kselftest is not focusing in those (but LTP does).
>> I do like the direction though. Also please run get_maintainer.pl and cc everybody it suggests.
Done in v5.
Thanks a lot.
>>
>> thanks,
>> -- Shuah
> This commit re-organizes membarrier test, solving issues when testing
> LTS kernels. Now, the code:
>
> - always run the same amount of tests (even on older kernels).
> - allows each test to succeed, fail or be skipped independently.
> - allows testing features even when explicitly unsupported (force=1).
> - checks false positive/negative by checking ret code and errno.
> - can be extended easily: to expand an array with commands.
>
> Note: like this, the test is pretty close to the LTP membarrier basic
> tests, and both can be maintained together.
>
> Link: https://bugs.linaro.org/show_bug.cgi?id=3771
> Link: http://lists.linux.it/pipermail/ltp/2018-October/009578.html
> Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
> ---
--
Rafael D. Tinoco
Linaro Kernel Validation
prev parent reply other threads:[~2018-11-18 20:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 16:05 [PATCH] selftests: membarrier: fix test by checking supported commands Rafael David Tinoco
2018-07-30 16:13 ` Mathieu Desnoyers
2018-07-30 23:32 ` Shuah Khan
2018-07-31 3:15 ` Rafael David Tinoco
2018-08-08 14:09 ` Rafael David Tinoco
2018-08-09 20:21 ` [PATCH v2] " Rafael David Tinoco
2018-08-27 22:52 ` Shuah Khan
2018-09-03 2:12 ` [PATCH v3] membarrier_test: work in progress Rafael David Tinoco
2018-09-21 22:48 ` Shuah Khan
2018-09-03 19:04 ` [PATCH v4] selftests: membarrier: reorganized test for LTS supportability Rafael David Tinoco
2018-09-03 19:11 ` Rafael David Tinoco
2018-09-21 22:53 ` Shuah Khan
2018-11-09 15:49 ` [PATCH v5] selftests: membarrier: re-organize test Rafael David Tinoco
2018-11-18 20:44 ` Rafael David Tinoco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b31ee44-6463-6f6b-ca43-f03af8b06e35@linaro.org \
--to=rafael.tinoco@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).