From: Michal Simek <michal.simek@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>,
Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
Cc: <rajan.vaja@xilinx.com>, <manish.narani@xilinx.com>,
<zou_wei@huawei.com>, <amit.sunil.dhamne@xilinx.com>,
<lakshmi.sai.krishna.potthuri@xilinx.com>,
<wendy.liang@xilinx.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/6] firmware: xilinx: instantiate xilinx event manager driver
Date: Mon, 21 Jun 2021 13:58:07 +0200 [thread overview]
Message-ID: <4e43bd3f-26ae-e85d-7d32-2bebe5c09a5c@xilinx.com> (raw)
In-Reply-To: <1155e79d-7c66-d772-d5ce-7d346ee8d8a0@xilinx.com>
On 6/21/21 1:48 PM, Michal Simek wrote:
>
>
> On 5/28/21 5:59 PM, Abhyuday Godhasara wrote:
>> Register simple platform device to instantiate Xilinx event
>> manager driver.
>>
>> Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
>> Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>
>> ---
>> drivers/firmware/xilinx/zynqmp.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
>> index ce16a72..31f7857 100644
>> --- a/drivers/firmware/xilinx/zynqmp.c
>> +++ b/drivers/firmware/xilinx/zynqmp.c
>> @@ -23,6 +23,7 @@
>> #include <linux/hashtable.h>
>>
>> #include <linux/firmware/xlnx-zynqmp.h>
>> +#include <linux/firmware/xlnx-event-manager.h>
>> #include "zynqmp-debug.h"
>>
>> /* Max HashMap Order for PM API feature check (1<<7 = 128) */
>> @@ -31,6 +32,8 @@
>> static bool feature_check_enabled;
>> static DEFINE_HASHTABLE(pm_api_features_map, PM_API_FEATURE_CHECK_MAX_ORDER);
>>
>> +static struct platform_device *em_dev;
>> +
>> /**
>> * struct pm_api_feature_data - PM API Feature data
>> * @pm_api_id: PM API Id, used as key to index into hashmap
>> @@ -1412,6 +1415,15 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
>>
>> zynqmp_pm_api_debugfs_init();
>>
>> + np = of_find_compatible_node(NULL, NULL, "xlnx,versal");
>> + if (np) {
>> + em_dev = platform_device_register_data(&pdev->dev, "xlnx_event_manager",
>> + -1, NULL, 0);
>> + if (IS_ERR(em_dev))
>> + dev_err_probe(&pdev->dev, PTR_ERR(pdev), "EM register fail with error\n");
Above you have IS_ERR(em_dev) and here PTR_ERR(pdev) this should be
PTR_ERR(em_dev).
>> + }
>> + of_node_put(np);
>> +
>> return of_platform_populate(dev->of_node, NULL, NULL, dev);
>> }
>>
>> @@ -1429,6 +1441,8 @@ static int zynqmp_firmware_remove(struct platform_device *pdev)
>> kfree(feature_data);
>> }
>>
>> + platform_device_unregister(em_dev);
>> +
>> return 0;
>> }
>>
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
With above fixed please add this line.
Thanks,
Michal
next prev parent reply other threads:[~2021-06-21 11:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1622217566-1856-1-git-send-email-abhyuday.godhasara@xilinx.com>
[not found] ` <1622217566-1856-3-git-send-email-abhyuday.godhasara@xilinx.com>
2021-06-21 11:11 ` [PATCH 2/6] firmware: xilinx: add macros of node ids for error event Michal Simek
2021-06-25 13:35 ` Abhyuday Godhasara
[not found] ` <1622217566-1856-2-git-send-email-abhyuday.godhasara@xilinx.com>
2021-06-21 11:45 ` [PATCH 1/6] firmware: xilinx: add register notifier in zynqmp firmware Michal Simek
2021-06-25 13:37 ` Abhyuday Godhasara
[not found] ` <1622217566-1856-4-git-send-email-abhyuday.godhasara@xilinx.com>
2021-06-21 11:46 ` [PATCH 3/6] firmware: xilinx: export the feature check of " Michal Simek
[not found] ` <1622217566-1856-6-git-send-email-abhyuday.godhasara@xilinx.com>
2021-06-21 11:48 ` [PATCH 5/6] firmware: xilinx: instantiate xilinx event manager driver Michal Simek
2021-06-21 11:58 ` Michal Simek [this message]
[not found] ` <1622217566-1856-5-git-send-email-abhyuday.godhasara@xilinx.com>
2021-06-21 11:55 ` [PATCH 4/6] drivers: soc: xilinx: add xilinx event management driver Michal Simek
2021-06-25 13:48 ` Abhyuday Godhasara
[not found] ` <1622217566-1856-7-git-send-email-abhyuday.godhasara@xilinx.com>
2021-06-21 12:00 ` [PATCH 6/6] driver: soc: xilinx: register for power events in zynqmp power driver Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e43bd3f-26ae-e85d-7d32-2bebe5c09a5c@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=abhyuday.godhasara@xilinx.com \
--cc=amit.sunil.dhamne@xilinx.com \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=wendy.liang@xilinx.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).