From: Ray Jui <ray.jui@broadcom.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-rpi-kernel@lists.infradead.org,
Eric Anholt <eric@anholt.net>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"open list:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..."
<bcm-kernel-feedback-list@broadcom.com>,
"moderated list:ARM SUB-ARCHITECTURES"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/32] arm64: Add platform selection for BCM2835.
Date: Thu, 2 Jun 2016 09:25:17 -0700 [thread overview]
Message-ID: <4e72ae37-a018-a17d-6a58-8450db58d1c7@broadcom.com> (raw)
In-Reply-To: <1464849936.24775.33.camel@redhat.com>
On 6/1/2016 11:45 PM, Gerd Hoffmann wrote:
>>> config ARCH_BCM2835
>>> bool "Broadcom BCM2835 family"
>>> - depends on ARCH_MULTI_V6 || ARCH_MULTI_V7
>>> + depends on ARCH_MULTI_V6 || ARCH_MULTI_V7 || ARM64
>>
>> Humm, what does that achieve?
>
> Nothing ;)
>
> Slipped through unnoticed, I'll drop it.
>
>>> +config ARCH_BCM
>>> + bool "Broadcom SoC Support"
>>> + help
>>> + This enables support for Broadcom ARM based SoC chips
>>
>> menuconfig maybe?
>
> There isn't any in arch/arm64/Kconfig.platforms right now, so I didn't
> feel like introducing one. Also the dependency should have pretty much
> the same effect ...
>
>>> +config ARCH_BCM2835
>>> + bool "Broadcom BCM2835 family"
>>> + depends on ARCH_BCM
>>> + select ARCH_REQUIRE_GPIOLIB
>>> + select CLKSRC_OF
>>> + select PINCTRL
>>> + select PINCTRL_BCM2835
>>> + select ARM_AMBA
>>> + select ARM_TIMER_SP804
>>> + select HAVE_ARM_ARCH_TIMER
>>> + help
>>> + This enables support for the Broadcom BCM2837 SoC.
>>> + This SoC is used in the Raspberry Pi 3 device.
>>> +
>>> config ARCH_BCM_IPROC
>>> bool "Broadcom iProc SoC Family"
>>> + depends on ARCH_BCM
>>
>> Does not seem necessary nor adding anything here.
>
> Added for consistency. When we add ARCH_BCM all ARCH_BCM_* should
> depend on it ...
>
> We could also do it the other way around: make ARCH_BCM a hidden bool
> and have ARCH_BCM_* select it.
Yes, this is probably better.
ARCH_BCM_IPROC is currently enabled in arch/arm64/configs/defconfig. By
adding a dependency here without enabling ARCH_BCM in arm64 defconfig,
this effectively disables ARCH_BCM_IPROC from arm64 defconfig.
>
> cheers,
> Gerd
>
next prev parent reply other threads:[~2016-06-02 16:25 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1464817421-8519-1-git-send-email-kraxel@redhat.com>
2016-06-01 21:43 ` [PATCH 01/32] arm64: Add platform selection for BCM2835 Gerd Hoffmann
2016-06-01 21:49 ` Florian Fainelli
2016-06-02 6:45 ` Gerd Hoffmann
2016-06-02 16:25 ` Ray Jui [this message]
2016-06-02 16:48 ` Scott Branden
2016-06-02 17:12 ` Gerd Hoffmann
2016-06-02 17:21 ` Scott Branden
2016-06-02 17:36 ` Florian Fainelli
2016-06-02 17:30 ` Catalin Marinas
2016-06-01 21:43 ` [PATCH 02/32] arm64: Add BCM2835 support to the defconfig Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 03/32] irqchip: bcm2835: Avoid arch/arm-specific handle_IRQ Gerd Hoffmann
2016-06-02 0:50 ` Jason Cooper
2016-06-02 18:06 ` Eric Anholt
2016-06-01 21:43 ` [PATCH 04/32] dt-bindings: Add root properties for Raspberry Pi 3 Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 05/32] ARM: bcm2835: Add devicetree for the " Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 06/32] arm64: Fix physical to DMA mappings Gerd Hoffmann
2016-06-02 17:20 ` Catalin Marinas
2016-06-01 21:43 ` [PATCH 07/32] ARM: bcm2835: dt: Add the ethernet to the device trees Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 08/32] ARM: bcm2837: " Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 09/32] bcm2837-rpi-3-b.dts for 32bit arm Gerd Hoffmann
2016-06-01 22:00 ` Arnd Bergmann
2016-06-01 22:30 ` Eric Anholt
2016-06-01 22:39 ` Arnd Bergmann
2016-06-02 6:56 ` Gerd Hoffmann
2016-06-02 7:24 ` Arnd Bergmann
2016-06-02 9:14 ` Gerd Hoffmann
2016-06-02 9:53 ` Arnd Bergmann
2016-06-02 15:11 ` Gerd Hoffmann
2016-06-02 15:23 ` Arnd Bergmann
2016-06-01 21:43 ` [PATCH 10/32] don't force serial pins to uart0 Gerd Hoffmann
2016-06-01 22:19 ` Arnd Bergmann
2016-06-02 18:19 ` Eric Anholt
2016-06-01 21:43 ` [PATCH 11/32] ARM: bcm2835: Define standard pinctrl groups in the gpio node Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 12/32] ARM: bcm2835: Replace alt0/i2s_alt[02] with standard groups Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 13/32] bcm2837-rpi-3-b.dts: add gpio Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 14/32] bcm2837-rpi-3-b.dts: vc4 hdmi fixup Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 15/32] ARM: bcm2835: Move the emmc pin group to bcm283x.dtsi Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 16/32] bcm2837-rpi-3-b.dts: move the emmc pin group Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 17/32] ARM: bcm2835: Add a group for mapping pins 48-53 to sdhost Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 18/32] ARM: bcm2835: Move most RPi default pin groups to their devices Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 19/32] bcm2837-rpi-3-b.dts: move " Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 20/32] dt-bindings: Add binding for brcm,bcm2835-sdhost Gerd Hoffmann
2016-06-06 13:12 ` Rob Herring
2016-06-01 21:43 ` [PATCH 21/32] mmc: bcm2835-sdhost: Add new driver for the internal SD controller Gerd Hoffmann
2016-06-01 22:18 ` Arnd Bergmann
2016-06-02 18:12 ` Eric Anholt
2016-06-03 8:42 ` Arnd Bergmann
2016-06-21 12:33 ` Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 22/32] ARM: bcm2835: Include SDHOST in the device tree Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 23/32] ARM: bcm2835: Enable SDHOST by default Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 24/32] i2c: bcm2835: Don't complain on -EPROBE_DEFER from getting our clock Gerd Hoffmann
2016-07-22 7:26 ` Wolfram Sang
2016-06-01 21:43 ` [PATCH 25/32] dt-gpio-fix Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 26/32] enable uart1 on the BT pins Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 27/32] gpio: Add support for the FXL6408 GPIO expander Gerd Hoffmann
2016-06-06 23:50 ` Eric Anholt
2016-06-07 0:02 ` Florian Fainelli
2016-06-08 9:10 ` Linus Walleij
2016-06-09 17:22 ` Eric Anholt
2016-06-01 21:43 ` [PATCH 28/32] i2c: bcm2835: Set up the rising/falling edge delays Gerd Hoffmann
2016-07-22 7:26 ` Wolfram Sang
2016-06-01 21:43 ` [PATCH 29/32] ARM: bcm2835: Use i2c-gpio for the expander, instead Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 30/32] ARM: bcm2835: Add a new EMMC pin group from the downstream tree Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 31/32] enable wireless Gerd Hoffmann
2016-06-01 21:43 ` [PATCH 32/32] mmc: bcm2835: Import bcm2835-mmc and switch to it Gerd Hoffmann
2016-06-02 16:52 ` Stefan Wahren
2016-06-02 18:18 ` Eric Anholt
2016-06-02 19:09 ` Stefan Wahren
2016-06-02 20:03 ` Gerd Hoffmann
2016-06-02 21:40 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e72ae37-a018-a17d-6a58-8450db58d1c7@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=kraxel@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).