From: Marek Vasut <marex@denx.de>
To: Rogerio Pimentel <rpimentel.silva@gmail.com>,
dmitry.torokhov@gmail.com, hansemro@outlook.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ili210x - Set the device name according to the device model
Date: Wed, 1 Sep 2021 21:46:35 +0200 [thread overview]
Message-ID: <4e8ad91c-2554-4b8f-94db-aa5add5f524d@denx.de> (raw)
In-Reply-To: <20210901192229.29864-1-rpimentel.silva@gmail.com>
On 9/1/21 9:22 PM, Rogerio Pimentel wrote:
[...]
> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
> index 30576a5f2f04..ca7af4a6f588 100644
> --- a/drivers/input/touchscreen/ili210x.c
> +++ b/drivers/input/touchscreen/ili210x.c
> @@ -19,6 +19,8 @@
> #define ILI251X_DATA_SIZE1 31
> #define ILI251X_DATA_SIZE2 20
>
> +#define ILI_NAME_LEN 27
> +
> /* Touchscreen commands */
> #define REG_TOUCHDATA 0x10
> #define REG_PANEL_INFO 0x20
> @@ -394,6 +396,7 @@ static int ili210x_i2c_probe(struct i2c_client *client,
> struct input_dev *input;
> int error;
> unsigned int max_xy;
> + char *model_name;
>
> dev_dbg(dev, "Probing for ILI210X I2C Touschreen driver");
>
> @@ -440,7 +443,11 @@ static int ili210x_i2c_probe(struct i2c_client *client,
> i2c_set_clientdata(client, priv);
>
> /* Setup input device */
> - input->name = "ILI210x Touchscreen";
> + input->name = "Ilitek Touchscreen";
> + model_name = (char *)input->name;
> + snprintf(model_name, ILI_NAME_LEN, "Ilitek %s Touchscreen",
Which ilitek devices do you have available exactly ?
There is a firmware interface which does report the device type, but I
don't know whether it works on all the ilitek touchscreen devices. If it
does, then it could be used here to pull the type from the firmware and
then use this instead
snprintf(model_name, ILI_NAME_LEN, "Ilitek ILI%04x Touchscreen", type);
Try this command against the touch controller, it sends it command 0x61
and reads two bytes of the reply:
i2ctransfer -f -y 1 w1@0x41 0x61 r2
0x10 0x25 # <---- on ILI2510 it reports 0x25 0x10 in reverse
next prev parent reply other threads:[~2021-09-01 19:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 19:22 [PATCH] Input: ili210x - Set the device name according to the device model Rogerio Pimentel
2021-09-01 19:46 ` Marek Vasut [this message]
2021-09-01 20:27 ` Rogerio Pimentel
2021-09-01 20:48 ` Marek Vasut
2021-09-02 12:39 ` Rogerio Pimentel
2021-09-02 12:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e8ad91c-2554-4b8f-94db-aa5add5f524d@denx.de \
--to=marex@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=hansemro@outlook.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpimentel.silva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).