From: Dave Hansen <dave.hansen@linux.intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH] x86/cpu, x86/pti: Do not enable PTI on AMD processors
Date: Wed, 27 Dec 2017 00:48:09 -0800 [thread overview]
Message-ID: <4ecfab84-ae81-2e00-9004-8d0ccf863f76@linux.intel.com> (raw)
In-Reply-To: <20171227054354.20369.94587.stgit@tlendack-t1.amdoffice.net>
On 12/26/2017 09:43 PM, Tom Lendacky wrote:
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -923,8 +923,8 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
>
> setup_force_cpu_cap(X86_FEATURE_ALWAYS);
>
> - /* Assume for now that ALL x86 CPUs are insecure */
> - setup_force_cpu_bug(X86_BUG_CPU_INSECURE);
> + if (c->x86_vendor != X86_VENDOR_AMD)
> + setup_force_cpu_bug(X86_BUG_CPU_INSECURE);
Does this disable it in a way that it can be turned back on via the
kernel command-line?
This is a rather wide class of issues and I would rather not just
hard-code it in a way that we say one vendor has never and will never be
affected.
next prev parent reply other threads:[~2017-12-27 8:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 5:43 [PATCH] x86/cpu, x86/pti: Do not enable PTI on AMD processors Tom Lendacky
2017-12-27 8:48 ` Dave Hansen [this message]
2017-12-27 14:47 ` Tom Lendacky
2017-12-28 0:20 ` Borislav Petkov
2018-01-03 16:21 ` [tip:x86/pti] " tip-bot for Tom Lendacky
2018-02-12 15:26 ` [PATCH] " Pavel Machek
2018-02-12 15:37 ` Brian Gerst
2018-02-13 13:21 ` Thomas Gleixner
2018-01-03 11:07 Ivan Ivanov
2018-01-03 19:38 Tim Mouraveiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ecfab84-ae81-2e00-9004-8d0ccf863f76@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).