From: Vlastimil Babka <vbabka@suse.cz>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>
Cc: Hugh Dickins <hughd@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.cz>
Subject: Re: [patch] mm, compaction: ignore watermarks when isolating free pages
Date: Thu, 16 Jun 2016 09:15:42 +0200 [thread overview]
Message-ID: <4f5ba93e-8bf0-151e-57eb-cad1a4823b9e@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.10.1606151530590.37360@chino.kir.corp.google.com>
On 06/16/2016 12:34 AM, David Rientjes wrote:
> The goal of memory compaction is to defragment memory by moving migratable
> pages to free pages at the end of the zone. No additional memory is being
> allocated.
>
> Ignore per-zone low watermarks in __isolate_free_page() because memory is
> either fully migrated or isolated free pages are returned when migration
> fails.
Michal Hocko suggested that too, but I didn't think it safe that
compaction should go below the min watermark, even temporarily. It means
the system is struggling with order-0 allocations, so making it worse
for the benefit of high-order allocations doesn't make sense. The
high-order allocation would likely fail anyway due to watermark checks,
even if the page of sufficient order was formed by compaction. So in my
series, I just changed the low watermark check to min [1].
> This fixes an issue where the compaction freeing scanner can isolate
> memory but the zone drops below its low watermark for that page order, so
> the scanner must continue to scan all memory pointlessly.
Good point, looks like failing the watermark is the only reason when
__isolate_free_page() can fail. isolate_freepages_block() and its
callers should take this as an indication that compaction should return
with failure immediately.
[1] http://article.gmane.org/gmane.linux.kernel/2231369
> Signed-off-by: David Rientjes <rientjes@google.com>
> ---
> mm/page_alloc.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2484,23 +2484,14 @@ EXPORT_SYMBOL_GPL(split_page);
>
> int __isolate_free_page(struct page *page, unsigned int order)
> {
> - unsigned long watermark;
> struct zone *zone;
> - int mt;
> + const int mt = get_pageblock_migratetype(page);
>
> BUG_ON(!PageBuddy(page));
> -
> zone = page_zone(page);
> - mt = get_pageblock_migratetype(page);
> -
> - if (!is_migrate_isolate(mt)) {
> - /* Obey watermarks as if the page was being allocated */
> - watermark = low_wmark_pages(zone) + (1 << order);
> - if (!zone_watermark_ok(zone, 0, watermark, 0, 0))
> - return 0;
>
> + if (!is_migrate_isolate(mt))
> __mod_zone_freepage_state(zone, -(1UL << order), mt);
> - }
>
> /* Remove page from free list */
> list_del(&page->lru);
> @@ -2520,7 +2511,6 @@ int __isolate_free_page(struct page *page, unsigned int order)
> }
> }
>
> -
> return 1UL << order;
> }
>
>
next prev parent reply other threads:[~2016-06-16 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 22:34 [patch] mm, compaction: ignore watermarks when isolating free pages David Rientjes
2016-06-16 7:15 ` Vlastimil Babka [this message]
2016-06-20 22:27 ` [patch] mm, compaction: abort free scanner if split fails David Rientjes
2016-06-21 11:43 ` Vlastimil Babka
2016-06-21 20:43 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f5ba93e-8bf0-151e-57eb-cad1a4823b9e@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.cz \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).