From: "平松雅巳 / HIRAMATU,MASAMI" <masami.hiramatsu.pt@hitachi.com>
To: "'Arnaldo Carvalho de Melo'" <acme@kernel.org>
Cc: David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: perf probe -L sys_select or sys_poll
Date: Tue, 11 Aug 2015 22:59:32 +0000 [thread overview]
Message-ID: <50399556C9727B4D88A595C8584AAB37524B4062@GSjpTKYDCembx32.service.hitachi.net> (raw)
In-Reply-To: <20150811141827.GJ2521@kernel.org>
Hi Arnaldo,
> From: Arnaldo Carvalho de Melo [mailto:acme@kernel.org]
>
> Hi Masami,
>
> Have you noticed that sys_select or sys_poll stops after the
> first few lines? Please let me know if you need more info than is below.
OK, I'll see what is going.
>
> [root@zoo ~]# perf probe -L sys_select
> <SyS_select@/home/git/linux/fs/select.c:0>
> 0 SYSCALL_DEFINE5(select, int, n, fd_set __user *, inp, fd_set __user *, outp,
> fd_set __user *, exp, struct timeval __user *, tvp)
> {
> struct timespec end_time, *to = NULL;
>
> [root@zoo ~]# perf probe -L sys_poll
> <SyS_poll@/home/git/linux/fs/select.c:0>
> 0 SYSCALL_DEFINE3(poll, struct pollfd __user *, ufds, unsigned int, nfds,
> int, timeout_msecs)
> {
> struct timespec end_time, *to = NULL;
>
> [root@zoo ~]#
>
> I haven't investigated it too much, if there is some trouble that makes
> 'perf probe -L' to stop like that maybe we should warn the user somehow?
It seems a bug of -L, since it works correctly with fs/select.c:957.
$ ./perf probe -L fs/select.c:957
</home/mhiramat/ksrc/linux-3/fs/select.c:957>
957 SYSCALL_DEFINE3(poll, struct pollfd __user *, ufds, unsigned int, nfds$
int, timeout_msecs)
{
960 struct timespec end_time, *to = NULL;
int ret;
963 if (timeout_msecs >= 0) {
964 to = &end_time;
965 poll_select_set_timeout(to, timeout_msecs / MSEC_PER_SE$
966 NSEC_PER_MSEC * (timeout_msecs % MSEC_PER_SEC))$
}
969 ret = do_sys_poll(ufds, nfds, to);
971 if (ret == -EINTR) {
struct restart_block *restart_block;
So, something goes wrong when processing syscall functions.
Thanks!
--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2015-08-11 22:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 14:18 perf probe -L sys_select or sys_poll Arnaldo Carvalho de Melo
2015-08-11 22:59 ` 平松雅巳 / HIRAMATU,MASAMI [this message]
2015-08-12 0:49 ` 平松雅巳 / HIRAMATU,MASAMI
2015-08-12 1:24 ` [BUGFIX PATCH perf/core ] perf-probe: Fix to show lines of sys_ functions correctly Masami Hiramatsu
2015-08-12 13:23 ` Arnaldo Carvalho de Melo
2015-08-12 13:40 ` Arnaldo Carvalho de Melo
2015-08-12 21:37 ` 平松雅巳 / HIRAMATU,MASAMI
2015-08-13 8:06 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50399556C9727B4D88A595C8584AAB37524B4062@GSjpTKYDCembx32.service.hitachi.net \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).