linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>, NeilBrown <neilb@suse.de>,
	Benoit Cousson <b-cousson@ti.com>, Felipe Balbi <balbi@ti.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] mfd: twl: Move PWM driver to PWM framework
Date: Mon, 03 Sep 2012 11:11:56 +0300	[thread overview]
Message-ID: <5044664C.5010508@ti.com> (raw)
In-Reply-To: <1346582458-7890-1-git-send-email-thierry.reding@avionic-design.de>

Hi,

On 09/02/2012 01:40 PM, Thierry Reding wrote:
> Hi,
> 
> This mini series replaces the twl_has_*() macros by the equivalent
> standard IS_ENABLED() macro and moves the PWM driver to the PWM
> framework.
> 
> I'll take the second patch through the PWM tree but would like to have
> some Acked-bys from people that know and have the hardware and can
> verify that I haven't broken anything.

All looks good for me but I have one comment for patch 2.

> 
> Thierry
> 
> Thierry Reding (2):
>   mfd: twl: Replace twl_has_*() macros by IS_ENABLED()
>   pwm: Move TWL6030 PWM driver to PWM framework
> 
>  drivers/mfd/Kconfig       |  10 ---
>  drivers/mfd/Makefile      |   1 -
>  drivers/mfd/twl-core.c    | 124 ++++++++-----------------------
>  drivers/mfd/twl6030-pwm.c | 165 -----------------------------------------
>  drivers/pwm/Kconfig       |   9 +++
>  drivers/pwm/Makefile      |   1 +
>  drivers/pwm/pwm-twl6030.c | 184 ++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 226 insertions(+), 268 deletions(-)
>  delete mode 100644 drivers/mfd/twl6030-pwm.c
>  create mode 100644 drivers/pwm/pwm-twl6030.c
> 


-- 
Péter

  parent reply	other threads:[~2012-09-03  8:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-02 10:40 [PATCH 0/2] mfd: twl: Move PWM driver to PWM framework Thierry Reding
2012-09-02 10:40 ` [PATCH 1/2] mfd: twl: Replace twl_has_*() macros by IS_ENABLED() Thierry Reding
2012-09-18  7:31   ` Peter Ujfalusi
2012-09-02 10:40 ` [PATCH 2/2] pwm: Move TWL6030 PWM driver to PWM framework Thierry Reding
2012-09-03  8:15   ` Peter Ujfalusi
2012-09-07 13:17     ` Thierry Reding
2012-09-03  8:11 ` Peter Ujfalusi [this message]
2012-09-07 13:19   ` [PATCH 0/2] mfd: twl: Move " Thierry Reding
2012-09-07 13:52     ` Peter Ujfalusi
2012-09-18  7:07       ` Thierry Reding
2012-09-18  7:32         ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5044664C.5010508@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=sameo@linux.intel.com \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).