From: Christopher Heiny <cheiny@synaptics.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jean Delvare <khali@linux-fr.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Allie Xiong <axiong@synaptics.com>,
William Manson <wmanson@synaptics.com>,
Peichen Chang <peichen.chang@synaptics.com>,
Joerie de Gram <j.de.gram@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Linus Walleij <linus.walleij@stericsson.com>,
Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>,
Henrik Rydberg <rydberg@euromail.se>
Subject: Re: [RFC PATCH 8/17] input: RMI4 F09 Built-In Self Test
Date: Tue, 4 Sep 2012 17:21:13 -0700 [thread overview]
Message-ID: <50469AF9.7010508@synaptics.com> (raw)
In-Reply-To: <CACRpkdaq7StwG_jg+hZCcU668=VrcUeZa7qP6R_2v9ugkkX38w@mail.gmail.com>
On 08/27/2012 03:07 PM, Linus Walleij wrote:
[snip]
>> >+static struct device_attribute attrs[] = {
>> >+ __ATTR(status, RMI_RW_ATTR,
>> >+ rmi_f09_status_show, rmi_f09_status_store),
>> >+ __ATTR(limitRegisterCount, RMI_RO_ATTR,
>> >+ rmi_f09_limit_register_count_show, rmi_store_error),
>> >+ __ATTR(hostTestEnable, RMI_RW_ATTR,
>> >+ rmi_f09_host_test_enable_show, rmi_f09_host_test_enable_store),
>> >+ __ATTR(internalLimits, RMI_RO_ATTR,
>> >+ rmi_f09_internal_limits_show, rmi_store_error),
>> >+ __ATTR(resultRegisterCount, RMI_RO_ATTR,
>> >+ rmi_f09_result_register_count_show, rmi_store_error),
>> >+ __ATTR(overall_bist_result, RMI_RO_ATTR,
>> >+ rmi_f09_overall_bist_result_show, rmi_store_error),
>> >+ __ATTR(test_number_control, RMI_RW_ATTR,
>> >+ rmi_f09_test_number_control_show,
>> >+ rmi_f09_test_number_control_store),
>> >+ __ATTR(test_result1, RMI_RO_ATTR,
>> >+ rmi_f09_test_result1_show, rmi_store_error),
>> >+ __ATTR(test_result2, RMI_RO_ATTR,
>> >+ rmi_f09_test_result2_show, rmi_store_error),
>> >+ __ATTR(run_bist, RMI_RW_ATTR,
>> >+ rmi_f09_run_bist_show, rmi_f09_run_bist_store),
>> >+ __ATTR(f09_control_test1, RMI_RW_ATTR,
>> >+ rmi_f09_control_test1_show, rmi_f09_control_test1_store),
>> >+ __ATTR(f09_control_test2, RMI_RW_ATTR,
>> >+ rmi_f09_control_test2_show, rmi_f09_control_test2_store),
>> >+};
> If this is*only* for tests, then for sure this should be in debugfs?
F09 is used in the final product (for example, a phone or tablet) both
on the production line and to diagnose failures in returned products.
We can't be certain that the phone/tablet/whatever manufacturer will
include debugfs in their production kernel, and if they don't they
almost certainly won't want to install a different kernel on the
production line to run a test, so we provided a sysfs interface to this.
>
>> >+static int rmi_f09_alloc_memory(struct rmi_function_container *fc)
> (...)
>> >+static void rmi_f09_free_memory(struct rmi_function_container *fc)
> Why do you need separate functions for these two?
>
> If they are only used from one place (which I suspect) then just
> put the code at that site.
Some of the other modules have fairly large and complicated
alloc_memory() and free_memory() implementations, so we adopted this as
a general convention in all the RMI function implementations. But as
you suggested elsewhere, using devm_kzalloc could tidy things up a lot,
in which case the functions could be merged back into their callers.
[snip]
next prev parent reply other threads:[~2012-09-05 0:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 22:17 [RFC PATCH 00/11] input: Synaptics RMI4 Touchscreen Driver Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 1/17] input: RMI4 public header file and documentation Christopher Heiny
2012-08-22 19:08 ` Linus Walleij
2012-08-22 21:45 ` Dmitry Torokhov
2012-08-23 0:26 ` Christopher Heiny
2012-08-22 23:35 ` Rafael J. Wysocki
2012-08-17 22:17 ` [RFC PATCH 2/17] input: RMI4 core bus and sensor drivers Christopher Heiny
2012-08-23 8:55 ` Linus Walleij
2012-09-25 23:53 ` Christopher Heiny
2012-09-26 11:39 ` Linus Walleij
2012-08-17 22:17 ` [RFC PATCH 3/17] input: RMI4 physical layer drivers for I2C and SPI Christopher Heiny
2012-08-23 13:21 ` Linus Walleij
2012-08-17 22:17 ` [RFC PATCH 4/17] input: RMI4 configs and makefiles Christopher Heiny
2012-08-27 18:39 ` Linus Walleij
2012-08-17 22:17 ` [RFC PATCH 5/17] input: rmidev character driver for RMI4 sensors Christopher Heiny
2012-08-27 18:49 ` Linus Walleij
2012-09-05 0:26 ` Christopher Heiny
2012-09-05 8:29 ` Linus Walleij
2012-08-17 22:17 ` [RFC PATCH 6/17] input: RMI4 firmware update Christopher Heiny
2012-08-27 21:01 ` Linus Walleij
2012-08-17 22:17 ` [RFC PATCH 7/17] input: RMI4 F01 device control Christopher Heiny
2012-08-27 21:59 ` Linus Walleij
2012-08-17 22:17 ` [RFC PATCH 8/17] input: RMI4 F09 Built-In Self Test Christopher Heiny
2012-08-27 22:07 ` Linus Walleij
2012-09-05 0:21 ` Christopher Heiny [this message]
2012-08-17 22:17 ` [RFC PATCH 9/17] input: RMI4 F11 multitouch sensing Christopher Heiny
2012-08-27 22:50 ` Linus Walleij
2012-08-17 22:17 ` [RFC PATCH 10/17] input: RM4 F17 Pointing sticks Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 11/17] input: RMI4 F19 capacitive buttons Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 12/17] input: RMI4 F1A simple " Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 13/17] input: RMI4 F21 Force sensing Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 14/17] input: RMI4 F30 GPIO/LED control Christopher Heiny
2012-08-27 22:58 ` Linus Walleij
2012-09-05 0:28 ` Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 15/17] input: RMI4 F34 device reflash Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 16/17] input: RMI4 F41 Active pen 2D input Christopher Heiny
2012-08-17 22:17 ` [RFC PATCH 17/17] input: RMI4 F54 analog data reporting Christopher Heiny
2012-08-27 23:01 ` Linus Walleij
2012-09-05 0:38 ` Christopher Heiny
2012-08-22 12:50 ` [RFC PATCH 00/11] input: Synaptics RMI4 Touchscreen Driver Linus Walleij
2012-08-22 21:29 ` Christopher Heiny
2012-08-27 23:20 ` Christopher Heiny
2012-08-28 0:12 ` Linus Walleij
2012-08-27 23:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50469AF9.7010508@synaptics.com \
--to=cheiny@synaptics.com \
--cc=axiong@synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=j.de.gram@gmail.com \
--cc=khali@linux-fr.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=naveen.gaddipati@stericsson.com \
--cc=peichen.chang@synaptics.com \
--cc=rydberg@euromail.se \
--cc=w.sang@pengutronix.de \
--cc=wmanson@synaptics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).