From: Wen Congyang <wency@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
x86@kernel.org, linux-pm@vger.kernel.org, len.brown@intel.com,
pavel@ucw.cz, rjw@sisk.pl, tglx@linutronix.de,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
rusty@rustcorp.com.au, bhelgaas@google.com,
David Rientjes <rientjes@google.c>
Subject: Re: [PATCH 2/2] numa: don't check if node is NUMA_NO_NODE
Date: Tue, 18 Sep 2012 09:38:01 +0800 [thread overview]
Message-ID: <5057D079.6020709@cn.fujitsu.com> (raw)
In-Reply-To: <20120904161102.143ceb6d.akpm@linux-foundation.org>
At 09/05/2012 07:11 AM, Andrew Morton Wrote:
> On Mon, 03 Sep 2012 16:12:12 +0800
> Wen Congyang <wency@cn.fujitsu.com> wrote:
>
>> If we don't debug per_cpu maps, the cpu's node is stored in per_cpu variable
>> numa_node. If node is NUMA_NO_NODE, it means the caller want to clear the
>> cpu's node. So we should also call set_cpu_numa_node() in this case.
>
> The changelog is missing important information.
>
> What is the runtime effect of the patch? In other words, please fully
> describe the runtime effects of the bug which the patch fixed.
>
> Please always provide this information. It will help others decide
> which kernel version(s) should be patched, and will help the
> maintainers of other kernel trees (especially vendor trees) to work out
> whether they should backport the fix into their kernels.
Sorry for later reply. I found this bug when I try to fix a bug by patch 1/2
(The bug is descriptioned in patch 1/2).
Thanks
Wen Congyang
>
>> --- a/arch/x86/mm/numa.c
>> +++ b/arch/x86/mm/numa.c
>> @@ -97,8 +97,7 @@ void __cpuinit numa_set_node(int cpu, int node)
>> #endif
>> per_cpu(x86_cpu_to_node_map, cpu) = node;
>>
>> - if (node != NUMA_NO_NODE)
>> - set_cpu_numa_node(cpu, node);
>> + set_cpu_numa_node(cpu, node);
>> }
>>
>> void __cpuinit numa_clear_node(int cpu)
>
>
prev parent reply other threads:[~2012-09-18 1:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 7:10 [PATCH 1/2] cpu_hotplug: unmap cpu2node when the cpu is hotremoved Wen Congyang
2012-09-03 8:12 ` [PATCH 2/2] numa: don't check if node is NUMA_NO_NODE Wen Congyang
2012-09-04 23:11 ` Andrew Morton
2012-09-18 1:38 ` Wen Congyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5057D079.6020709@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rientjes@google.c \
--cc=rjw@sisk.pl \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).