Re: [PATCH v2 0/3] Input: cyttsp4 - driver for Cypress TMA4XX touchscreen devices

From: Ferruh Yigit <fery@cypress.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Henrik Rydberg <rydberg@euromail.se>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Kevin McNeely <kev@cypress.com>,
	Phil Warkentin <pwar@cypress.com>,
	Shawn Landden <shawnlandden@gmail.com>,
	Ashish Jangam <ashish.jangam@kpitcummins.com>,
	Olivier Sobrie <olivier@sobrie.be>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Input: cyttsp4 - driver for Cypress TMA4XX touchscreen devices
Date: Wed, 19 Sep 2012 15:02:36 +0300	[thread overview]
Message-ID: <5059B45C.2010105@cypress.com> (raw)
In-Reply-To: <CABxcv=n0+xywzSTiuNFMd+BvLGaNOVZVDqWYJWRXxU=DkJiYLw@mail.gmail.com>

On 09/15/2012 06:42 PM, Javier Martinez Canillas wrote:
> On Fri, Sep 14, 2012 at 8:46 PM, Henrik Rydberg <rydberg@euromail.se> wrote:
>> Hi Ferruh,
>>
>>> This driver is for Cypress TrueTouch(tm) Standard Product controllers,
>>> Generation4 devices.
>>>
>>> This is second version of driver, code re-structured to match with
>>> existing Generation3 driver code.
>> To integrate with the existing gen3 driver is clearly not the same as
>> creating a parallel set of files, which obviously share a lot of code
>> with the gen3 code.
>>
>> For instance, the i2c transfer layer seems more or less identical to
>> the existing one; just look at cyttsp_i2c_write_block_data() versus
>> cyttsp4_i2c_write_block_data(). If different generations of device
>> data cannot even be transported through the same _generic_ interface,
>> something is clearly not right.
>>
>> You can't seriously expect anyone to want to maintain one set of files
>> for every new version. Please make sure to build on what is already
>> there.
>>
>> Thanks.
>> Henrik
>> --
> Hi Ferruh,
>
> Thanks a lot for taking the time to try to modify your driver to fit
> wit the existent Gen3 driver but I agree with Henrik that it seems
> that at least the transport code from the Gen3 driver could be reused.
>
> As he said the i2c layer code is almost identical and even when there
> are some differences on the spi transfer functions I think that the
> current Gen3 spi transport code could be refactor to support it. These
> differences seems to be only minor as far as I understood by looking
> at cyttsp_spi_xfer() and cyttsp4_spi_xfer() functions.
>
> Also it seems that you forgot to post your 1/3 patch from your series
> that adds the Gen4 core driver. At least I couldn't find neither on my
> mailbox nor on linux-input archives the patch:
>
> [PATCH v2 1/3] Input: cyttsp4 - core driver for Cypress TMA4XX
> touchscreen devices
>
> So I couldn't take a look to try to figure out if the current Gen3
> core driver can be extended to support the new Gen4 family or if new
> core driver file is actually needed.
>
> Best regards,
> Javier
Hi Javier,

As you mentioned there is a difference on SPI because of protocol
difference.
But agreed that we can merge transport layer with existing driver.

We will at least start on merging transport layer of Gen4 driver with
existing driver.

Thanks & Best Regards,
ferruh

This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.