From: Dan Murphy <dmurphy@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
<robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lee.jones@linaro.org>,
<linux-omap@vger.kernel.org>, <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v7 1/6] dt-bindings: ti-lmu: Remove LM3697
Date: Fri, 21 Sep 2018 07:44:00 -0500 [thread overview]
Message-ID: <50e9aa50-99fb-0a1f-e395-c52bf91e8a7f@ti.com> (raw)
In-Reply-To: <20180920220443.GB27468@xo-6d-61-c0.localdomain>
Pavel
On 09/20/2018 05:04 PM, Pavel Machek wrote:
> Hi!
>
>>>>> Easy to maintain will be a dedicated LED class driver.
>>>>
>>>> You mean, 3 dedicated LED class drivers and 3 MFD drivers with LED
>>>> parts? We'll need complex driver anyway, and I'd really like to have
>>>> just one.
>>>
>>> In the LED subsystem we can wrap common functionalities
>>> into a library object. MFD driver will be able to reuse it then.
>>
>> I am currently working on that code now. I expect a RFC on this this week.
>
> Looking forward to that.
>
> But you really need acks for the bindings, and since Rob is usually quite slow
> acking them, it is easiest to use the existing binding... if it is wrong it
> needs to be fixed, anyway.
>
OK I am in the midst of creating the code now. I have the common code done I just need to
make sure that it scales to other devices in the list.
The bindings will need to be updated to follow the LED bindings binding style.
I am wondering for the non-MFD parts if we should move the bindings to the LED
directory to make them easier to find.
Dan
> THanks,
>
> Pavel
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2018-09-21 12:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 17:08 [PATCH v7 0/6] LM3697 dedicated LED driver Dan Murphy
2018-09-11 17:08 ` [PATCH v7 1/6] dt-bindings: ti-lmu: Remove LM3697 Dan Murphy
2018-09-11 18:14 ` Lee Jones
2018-09-11 20:05 ` Pavel Machek
2018-09-11 21:48 ` Dan Murphy
2018-09-12 21:49 ` Pavel Machek
2018-09-13 15:15 ` Dan Murphy
2018-09-14 8:18 ` Pavel Machek
2018-09-14 20:15 ` Jacek Anaszewski
2018-09-14 21:42 ` Pavel Machek
2018-09-15 20:00 ` Jacek Anaszewski
2018-09-17 15:24 ` Dan Murphy
2018-09-17 19:22 ` Jacek Anaszewski
2018-09-17 21:23 ` Dan Murphy
2018-09-20 22:04 ` Pavel Machek
2018-09-21 12:44 ` Dan Murphy [this message]
2018-09-14 8:23 ` Pavel Machek
2018-09-12 18:35 ` Jacek Anaszewski
2018-09-11 17:08 ` [PATCH v7 2/6] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2018-09-11 18:13 ` Lee Jones
2018-09-11 17:08 ` [PATCH v7 3/6] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-09-24 16:18 ` Rob Herring
2018-09-24 18:02 ` Pavel Machek
2018-09-25 19:39 ` Rob Herring
2018-09-25 21:19 ` Dan Murphy
2018-09-11 17:08 ` [PATCH v7 4/6] leds: lm3697: Introduce the " Dan Murphy
2018-09-11 17:08 ` [PATCH v7 5/6] dt-bindings: leds: Add runtime ramp node for LM3697 Dan Murphy
2018-09-11 17:08 ` [PATCH v7 6/6] leds: lm3697: Add ramp rate feature Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50e9aa50-99fb-0a1f-e395-c52bf91e8a7f@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).