From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C160C4338F for ; Wed, 4 Aug 2021 19:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 536AA61002 for ; Wed, 4 Aug 2021 19:27:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240756AbhHDT2H (ORCPT ); Wed, 4 Aug 2021 15:28:07 -0400 Received: from mga12.intel.com ([192.55.52.136]:25752 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240720AbhHDT2C (ORCPT ); Wed, 4 Aug 2021 15:28:02 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10066"; a="193587881" X-IronPort-AV: E=Sophos;i="5.84,295,1620716400"; d="scan'208";a="193587881" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2021 12:27:47 -0700 X-IronPort-AV: E=Sophos;i="5.84,295,1620716400"; d="scan'208";a="522091507" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.209.32.138]) ([10.209.32.138]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2021 12:27:45 -0700 Subject: Re: [PATCH v1] driver: base: Add driver filter support To: "Kuppuswamy, Sathyanarayanan" , Matthew Wilcox Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Jonathan Corbet , Dan Williams , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20210804174322.2898409-1-sathyanarayanan.kuppuswamy@linux.intel.com> <0e20cad3-8ba4-71bc-5bfd-3246ef991c6d@linux.intel.com> From: Andi Kleen Message-ID: <515ff3e6-d7aa-4d40-1cf7-7113721d68b9@linux.intel.com> Date: Wed, 4 Aug 2021 12:27:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <0e20cad3-8ba4-71bc-5bfd-3246ef991c6d@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/2021 11:29 AM, Kuppuswamy, Sathyanarayanan wrote: > > > On 8/4/21 11:08 AM, Matthew Wilcox wrote: >> Why use a doubly-linked-list here?  An allocating xarray should perform >> much better and use less memory. > > We don't expect the list to be too long. So we may not gain any > significant > advantage in terms of performance or memory when using alternate > lists. Since > linked list easier to use, we chose it. > Also even if it was long it wouldn't matter because this isn't a fast path at all. All that matters it to write the code as clearly as possible. -Andi