From: David Ahern <dsahern@gmail.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 3/3] perf tools: include termios.h explicitly
Date: Wed, 19 Jun 2013 08:52:06 -0600 [thread overview]
Message-ID: <51C1C596.10405@gmail.com> (raw)
In-Reply-To: <1371603750-15053-3-git-send-email-iamjoonsoo.kim@lge.com>
On 6/18/13 7:02 PM, Joonsoo Kim wrote:
> Building perf for android is failed, because it can't find definition of
> struct winsize. This definition is in termios.h, so I add this header
> to util.h to solve the problem. It is missed by commit '2c803e52' which
> moves get_term_dimensions() from builtin-top.c to util.c, but, missed to
> move termios.h header.
Thank you for fixing this.
David
>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index a45710b..f2c6483 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -72,6 +72,7 @@
> #include "types.h"
> #include <sys/ttydefaults.h>
> #include <lk/debugfs.h>
> +#include <termios.h>
>
> extern const char *graph_line;
> extern const char *graph_dotted_line;
> @@ -274,6 +275,5 @@ void dump_stack(void);
>
> extern unsigned int page_size;
>
> -struct winsize;
> void get_term_dimensions(struct winsize *ws);
> #endif /* GIT_COMPAT_UTIL_H */
>
next prev parent reply other threads:[~2013-06-19 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 1:02 [PATCH 1/3] perf record: support duration option to run during specified time Joonsoo Kim
2013-06-19 1:02 ` [PATCH 2/3] tools lib lk: Fix for cross build Joonsoo Kim
2013-07-12 8:50 ` [tip:perf/urgent] " tip-bot for Joonsoo Kim
2013-06-19 1:02 ` [PATCH 3/3] perf tools: include termios.h explicitly Joonsoo Kim
2013-06-19 11:33 ` Ingo Molnar
2013-06-19 12:16 ` Namhyung Kim
2013-06-20 1:45 ` Joonsoo Kim
2013-06-19 14:52 ` David Ahern [this message]
2013-07-12 8:49 ` [tip:perf/urgent] perf tools: Include " tip-bot for Joonsoo Kim
2013-06-29 0:27 ` [PATCH 1/3] perf record: support duration option to run during specified time Sukadev Bhattiprolu
2013-07-01 5:46 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C1C596.10405@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).