From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9079C43381 for ; Thu, 21 Feb 2019 16:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D8B52077B for ; Thu, 21 Feb 2019 16:24:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="s6qLc7AK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728563AbfBUQYk (ORCPT ); Thu, 21 Feb 2019 11:24:40 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:54062 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728456AbfBUQYj (ORCPT ); Thu, 21 Feb 2019 11:24:39 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x1LGOUNE013532; Thu, 21 Feb 2019 10:24:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1550766270; bh=fZccNQe3ZtMUmbjpjp3npLd9KdUtlI8cxKu66v7lRU0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=s6qLc7AK68WYHFKOflai4cDbvzJZ3Ty/16rOQASjxjXxZwktLHm3sFUnIdKuSM+VC ssxWWWNP6UXrph/r93Sr35dGLa91NWQtevsqCh2pTEyT8X98eDuneQQfNaf+rz8M+B MWRvOtj1nKJP7aWO2IGYQqqerbZ4p6Pe1ri0pSQk= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x1LGOUoR031816 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 Feb 2019 10:24:30 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 21 Feb 2019 10:24:29 -0600 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Thu, 21 Feb 2019 10:24:29 -0600 Received: from [172.22.78.2] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x1LGOTva021783; Thu, 21 Feb 2019 10:24:29 -0600 Subject: Re: [PATCH v5 0/5] M_CAN Framework re-write To: , , CC: , , References: <20190214182754.30721-1-dmurphy@ti.com> From: Dan Murphy Message-ID: <52148371-16aa-b87a-02f0-9037d5d34988@ti.com> Date: Thu, 21 Feb 2019 10:24:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190214182754.30721-1-dmurphy@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bump On 2/14/19 12:27 PM, Dan Murphy wrote: > Hello > > OK I did not give up on this patch series just got a little preoccupied with > some other kernel work. But here is the update per the comments. > > It should be understood I broke these out for reviewability. > For instance the first patch does not compile on its own as including this > patch should not change the current functionality and it pulls all the io-mapped > code from the m_can base file to a platfrom file. > > The next patch "Migrate the m_can code to use the framework" > is the change to the kernel for the io-mapped conversion from a flat file to use > the framework. Finally the rename patch just renames the m_can_priv to > m_can_classdev. I broke this change out specifically for readability of the > migration patch per comments on the code. > > AFAIC the first 3 patches can all be squashed into a single patch. Or the > first 2 patches in the series can be re-arranged but then m_can functionality is > affected in the migration patch. > > Again the first 3 patches here are all just for readability and review purposes. > > Dan > > Dan Murphy (5): > can: m_can: Create a m_can platform framework > can: m_can: Migrate the m_can code to use the framework > can: m_can: Rename m_can_priv to m_can_classdev > dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver > can: tcan4x5x: Add tcan4x5x driver to the kernel > > .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + > drivers/net/can/m_can/Kconfig | 14 +- > drivers/net/can/m_can/Makefile | 2 + > drivers/net/can/m_can/m_can.c | 788 +++++++++--------- > drivers/net/can/m_can/m_can.h | 159 ++++ > drivers/net/can/m_can/m_can_platform.c | 198 +++++ > drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ > 7 files changed, 1320 insertions(+), 409 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt > create mode 100644 drivers/net/can/m_can/m_can.h > create mode 100644 drivers/net/can/m_can/m_can_platform.c > create mode 100644 drivers/net/can/m_can/tcan4x5x.c > -- ------------------ Dan Murphy