From: John Johansen <john.johansen@canonical.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH 2/3] LSM: Fix kernel-doc
Date: Mon, 10 Oct 2022 19:07:55 -0700 [thread overview]
Message-ID: <5225f90f-eb9f-c3c3-c266-f1e52b29ba34@canonical.com> (raw)
In-Reply-To: <20221008063411.14829-2-jiapeng.chong@linux.alibaba.com>
On 10/7/22 23:34, Jiapeng Chong wrote:
> security/apparmor/lsm.c:753: warning: expecting prototype for apparmor_bprm_committed_cred(). Prototype was for apparmor_bprm_committed_creds() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2338
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: John Johansen <john.johansen@canonical.com>
I have pulled this into my tree
> ---
> security/apparmor/lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index cc83cbf2ce20..c56afd1307c1 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -746,7 +746,7 @@ static void apparmor_bprm_committing_creds(struct linux_binprm *bprm)
> }
>
> /**
> - * apparmor_bprm_committed_cred - do cleanup after new creds committed
> + * apparmor_bprm_committed_creds() - do cleanup after new creds committed
> * @bprm: binprm for the exec (NOT NULL)
> */
> static void apparmor_bprm_committed_creds(struct linux_binprm *bprm)
next prev parent reply other threads:[~2022-10-11 2:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 6:34 [PATCH 1/3] AppArmor: Fix kernel-doc Jiapeng Chong
2022-10-08 6:34 ` [PATCH 2/3] LSM: " Jiapeng Chong
2022-10-11 2:07 ` John Johansen [this message]
2022-10-08 6:34 ` [PATCH 3/3] AppArmor: " Jiapeng Chong
2022-10-11 2:08 ` John Johansen
2022-10-11 2:07 ` [PATCH 1/3] " John Johansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5225f90f-eb9f-c3c3-c266-f1e52b29ba34@canonical.com \
--to=john.johansen@canonical.com \
--cc=abaci@linux.alibaba.com \
--cc=apparmor@lists.ubuntu.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).