From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Daniel Axtens <dja@axtens.net>,
"Alastair D'Silva" <alastair@au1.ibm.com>
Cc: Michal Hocko <mhocko@suse.com>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
"Alastair D'Silva" <alastair@d-silva.org>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings
Date: Thu, 14 Mar 2019 11:09:42 +1100 [thread overview]
Message-ID: <52392d47-4b69-2353-b831-6db4250bed78@au1.ibm.com> (raw)
In-Reply-To: <87ef7atjnk.fsf@dja-thinkpad.axtens.net>
On 14/3/19 10:54 am, Daniel Axtens wrote:
>> +static inline struct paca_struct *get_paca_no_preempt_check(void)
>> +{
>> + register struct paca_struct *paca asm("r13");
>> + return paca;
>> +}
>
> Isn't the convention to have the { on the same line as the function, or
> am I horrible mis-remembering things?
However, there is one special case, namely functions: they have the
opening brace at the beginning of the next line, thus:
int function(int x)
{
body of function
}
Heretic people all over the world have claimed that this inconsistency
is ... well ... inconsistent, but all right-thinking people know that
(a) K&R are **right** and (b) K&R are right. Besides, functions are
special anyway (you can't nest them in C).
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2019-03-14 0:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 3:42 [PATCH 1/1] arch/powerpc: Rework local_paca to avoid LTO warnings Alastair D'Silva
2019-03-13 9:06 ` Christophe Leroy
2019-03-14 1:39 ` Alastair D'Silva
2019-03-13 23:54 ` Daniel Axtens
2019-03-14 0:09 ` Andrew Donnellan [this message]
2019-03-14 3:09 ` Alastair D'Silva
2019-03-14 2:31 ` [PATCH v2] " Alastair D'Silva
2019-03-14 5:46 ` Christophe Leroy
2019-03-26 5:58 ` Nicholas Piggin
2019-03-27 4:37 ` Alastair D'Silva
2019-03-27 6:02 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52392d47-4b69-2353-b831-6db4250bed78@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alastair@au1.ibm.com \
--cc=alastair@d-silva.org \
--cc=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mhocko@suse.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).