From: Bart Van Assche <bvanassche@acm.org>
To: Can Guo <cang@codeaurora.org>,
asutoshd@codeaurora.org, nguyenb@codeaurora.org,
hongwus@codeaurora.org, rnayak@codeaurora.org,
linux-scsi@vger.kernel.org, kernel-team@android.com,
saravanak@google.com, salyzyn@google.com
Cc: Sayali Lokhande <sayalil@codeaurora.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
Venkat Gopalakrishnan <venkatg@codeaurora.org>,
Tomas Winkler <tomas.winkler@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/8] scsi: ufs: Flush exception event before suspend
Date: Sat, 25 Jan 2020 19:29:55 -0800 [thread overview]
Message-ID: <525e4f67-f471-54a6-aaea-b3772a550af1@acm.org> (raw)
In-Reply-To: <1579764349-15578-2-git-send-email-cang@codeaurora.org>
On 2020-01-22 23:25, Can Guo wrote:
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 1201578..c2de29f 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4760,8 +4760,15 @@ static void ufshcd_slave_destroy(struct scsi_device *sdev)
> * UFS device needs urgent BKOPs.
> */
> if (!hba->pm_op_in_progress &&
> - ufshcd_is_exception_event(lrbp->ucd_rsp_ptr))
> - schedule_work(&hba->eeh_work);
> + ufshcd_is_exception_event(lrbp->ucd_rsp_ptr)) {
> + /*
> + * Prevent suspend once eeh_work is scheduled
> + * to avoid deadlock between ufshcd_suspend
> + * and exception event handler.
> + */
> + if (schedule_work(&hba->eeh_work))
> + pm_runtime_get_noresume(hba->dev);
> + }
Please combine the two logical tests with "&&" instead of nesting two
if-statements inside each other.
> break;
> case UPIU_TRANSACTION_REJECT_UPIU:
> /* TODO: handle Reject UPIU Response */
> @@ -5215,7 +5222,14 @@ static void ufshcd_exception_event_handler(struct work_struct *work)
>
> out:
> scsi_unblock_requests(hba->host);
> - pm_runtime_put_sync(hba->dev);
> + /*
> + * pm_runtime_get_noresume is called while scheduling
> + * eeh_work to avoid suspend racing with exception work.
> + * Hence decrement usage counter using pm_runtime_put_noidle
> + * to allow suspend on completion of exception event handler.
> + */
> + pm_runtime_put_noidle(hba->dev);
> + pm_runtime_put(hba->dev);
> return;
> }
>
> @@ -7901,6 +7915,7 @@ static int ufshcd_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
> goto enable_gating;
> }
>
> + flush_work(&hba->eeh_work);
> ret = ufshcd_link_state_transition(hba, req_link_state, 1);
> if (ret)
> goto set_dev_active;
I think this patch introduces a new race condition, namely the following:
- ufshcd_slave_destroy() tests pm_op_in_progress and reads the value
zero from that variable.
- ufshcd_suspend() sets hba->pm_op_in_progress to one.
- ufshcd_slave_destroy() calls schedule_work().
How about fixing this race condition by calling
pm_runtime_get_noresume() before checking pm_op_in_progress and by
reallowing resume if no work is scheduled?
Thanks,
Bart.
next prev parent reply other threads:[~2020-01-26 3:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1579764349-15578-1-git-send-email-cang@codeaurora.org>
2020-01-23 7:25 ` [PATCH v4 1/8] scsi: ufs: Flush exception event before suspend Can Guo
2020-01-23 23:09 ` [EXT] " Bean Huo (beanhuo)
2020-01-26 3:29 ` Bart Van Assche [this message]
2020-02-03 6:23 ` Can Guo
2020-02-04 3:12 ` Bart Van Assche
2020-02-04 6:28 ` Can Guo
2020-01-23 7:25 ` [PATCH v4 2/8] scsi: ufs: set load before setting voltage in regulators Can Guo
2020-01-23 7:50 ` hongwus
2020-01-23 7:25 ` [PATCH v4 3/8] scsi: ufs: Remove the check before call setup clock notify vops Can Guo
2020-01-23 7:25 ` [PATCH v4 4/8] scsi: ufs-qcom: Adjust bus bandwidth voting and unvoting Can Guo
2020-01-23 7:25 ` [PATCH v4 5/8] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic Can Guo
2020-01-24 18:07 ` Asutosh Das (asd)
2020-01-23 7:25 ` [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support Can Guo
2020-01-23 23:11 ` [EXT] " Bean Huo (beanhuo)
2020-02-03 7:17 ` Can Guo
2020-01-24 18:06 ` Asutosh Das (asd)
2020-01-26 3:34 ` Bart Van Assche
2020-02-03 7:16 ` Can Guo
2020-02-03 22:30 ` Bart Van Assche
2020-01-23 7:25 ` [PATCH v4 7/8] scsi: ufs-qcom: Delay specific time before gate ref clk Can Guo
2020-01-24 18:04 ` Asutosh Das (asd)
2020-01-23 7:25 ` [PATCH v4 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4 Can Guo
2020-01-24 18:03 ` Asutosh Das (asd)
2020-01-26 3:38 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525e4f67-f471-54a6-aaea-b3772a550af1@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
--cc=sayalil@codeaurora.org \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
--cc=venkatg@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).