From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26EAC433E1 for ; Mon, 18 May 2020 18:21:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CED54207C4 for ; Mon, 18 May 2020 18:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P1Ae4Jcm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387804AbgERSVA (ORCPT ); Mon, 18 May 2020 14:21:00 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:41671 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731703AbgERSU4 (ORCPT ); Mon, 18 May 2020 14:20:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589826054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgUgYOhXHVrOhAbBYxlnYyhMzdekwGrXn9fI5GzJacU=; b=P1Ae4JcmTm0WHLLAVaElH5dd9rU87sM7FkJZLRKSfEpQ1W+vh24p5OoRUEyXSMHavi2+O6 hyofZQ6yzv9FW4cIZOWwA/V4f5w47EuRXrN/yW5dL62ma3WCPjDUeiuN2Na9ibgT7BUb10 dYriE19REwII93v6UFtVKKn+YoNgRvs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-kVRrudnWNEOZ64966nyy_Q-1; Mon, 18 May 2020 14:20:52 -0400 X-MC-Unique: kVRrudnWNEOZ64966nyy_Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 428731005510; Mon, 18 May 2020 18:20:48 +0000 (UTC) Received: from ovpn-115-234.rdu2.redhat.com (ovpn-115-234.rdu2.redhat.com [10.10.115.234]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6AF23398; Mon, 18 May 2020 18:20:43 +0000 (UTC) Message-ID: <5260142047d0339e00d4a74865c2f0b7511c89f6.camel@redhat.com> Subject: Re: [PATCH 10/29] c6x: use asm-generic/cacheflush.h From: Mark Salter To: Christoph Hellwig , Andrew Morton , Arnd Bergmann , Roman Zippel Cc: linux-arch@vger.kernel.org, linux-xtensa@linux-xtensa.org, Michal Simek , Jessica Yu , linux-ia64@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-sh@vger.kernel.org, linux-hexagon@vger.kernel.org, x86@kernel.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, linux-alpha@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Date: Mon, 18 May 2020 14:20:42 -0400 In-Reply-To: <20200515143646.3857579-11-hch@lst.de> References: <20200515143646.3857579-1-hch@lst.de> <20200515143646.3857579-11-hch@lst.de> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-05-15 at 16:36 +0200, Christoph Hellwig wrote: > C6x needs almost no cache flushing routines of its own. Rely on > asm-generic/cacheflush.h for the defaults. > > Signed-off-by: Christoph Hellwig > --- > arch/c6x/include/asm/cacheflush.h | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/arch/c6x/include/asm/cacheflush.h b/arch/c6x/include/asm/cacheflush.h > index 4540b40475e6c..10922d528de6d 100644 > --- a/arch/c6x/include/asm/cacheflush.h > +++ b/arch/c6x/include/asm/cacheflush.h > @@ -16,21 +16,6 @@ > #include > #include > > -/* > - * virtually-indexed cache management (our cache is physically indexed) > - */ > -#define flush_cache_all() do {} while (0) > -#define flush_cache_mm(mm) do {} while (0) > -#define flush_cache_dup_mm(mm) do {} while (0) > -#define flush_cache_range(mm, start, end) do {} while (0) > -#define flush_cache_page(vma, vmaddr, pfn) do {} while (0) > -#define flush_cache_vmap(start, end) do {} while (0) > -#define flush_cache_vunmap(start, end) do {} while (0) > -#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 0 > -#define flush_dcache_page(page) do {} while (0) > -#define flush_dcache_mmap_lock(mapping) do {} while (0) > -#define flush_dcache_mmap_unlock(mapping) do {} while (0) > - > /* > * physically-indexed cache management > */ > @@ -49,14 +34,12 @@ do { \ > (unsigned long) page_address(page) + PAGE_SIZE)); \ > } while (0) > > - > #define copy_to_user_page(vma, page, vaddr, dst, src, len) \ > do { \ > memcpy(dst, src, len); \ > flush_icache_range((unsigned) (dst), (unsigned) (dst) + (len)); \ > } while (0) > > -#define copy_from_user_page(vma, page, vaddr, dst, src, len) \ > - memcpy(dst, src, len) > +#include > > #endif /* _ASM_C6X_CACHEFLUSH_H */ Acked-by: Mark Salter