From: "Peter Senna Tschudin" <peter.senna@collabora.co.uk>
To: "Rob Herring" <robh@kernel.org>
Cc: jslaby@suse.cz, dri-devel@lists.freedesktop.org,
martyn.welch@collabora.co.uk, tiwai@suse.com,
linux@armlinux.org.uk, galak@codeaurora.org,
peter.senna@gmail.com, architt@codeaurora.org,
"Fabio Estevam" <fabio.estevam@nxp.com>,
ijc+devicetree@hellion.org.uk, davem@davemloft.net,
mark.rutland@arm.com, rmk+kernel@armlinux.org.uk,
kernel@pengutronix.de, enric.balletbo@collabora.com,
mchehab@osg.samsung.com,
"Peter Senna Tschudin" <peter.senna@collabora.com>,
treding@nvidia.com, gregkh@linuxfoundation.org,
p.zabel@pengutronix.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, javier@dowhile0.org,
devicetree@vger.kernel.org, martin.donnelly@ge.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org,
eballetbo@gmail.com, pawel.moll@arm.com, airlied@linux.ie,
ykk@rock-chips.com, heiko@sntech.de, thierry.reding@gmail.com,
daniel.vetter@ffwll.ch, linux@roeck-us.net
Subject: Re: [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp
Date: Tue, 03 Jan 2017 23:34:04 +0000 [thread overview]
Message-ID: <529b-586c3500-5-5e05b080@98620974> (raw)
In-Reply-To: <20170103225127.jn36tatufdfz2k5q@rob-hp-laptop>
Hi Rob,
Thank you for the review.
On 03 January, 2017 23:51 CET, Rob Herring <robh@kernel.org> wrote:
> On Sun, Jan 01, 2017 at 09:24:29PM +0100, Peter Senna Tschudin wrote:
> > Devicetree bindings documentation for the GE B850v3 LVDS/DP++
> > display bridge.
> >
> > Cc: Martyn Welch <martyn.welch@collabora.co.uk>
> > Cc: Martin Donnelly <martin.donnelly@ge.com>
> > Cc: Javier Martinez Canillas <javier@dowhile0.org>
> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Signed-off-by: Peter Senna Tschudin <peter.senna@collabora.com>
> > ---
> > There was an Acked-by from Rob Herring <robh@kernel.org> for V6, but I changed
> > the bindings to use i2c_new_secondary_device() so I removed it from the commit
> > message.
> >
> > .../devicetree/bindings/ge/b850v3-lvds-dp.txt | 39 ++++++++++++++++++++++
>
> Generally, bindings are not organized by vendor. Put in
> bindings/display/bridge/... instead.
Will change that.
>
> > 1 file changed, 39 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
> >
> > diff --git a/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
> > new file mode 100644
> > index 0000000..1bc6ebf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ge/b850v3-lvds-dp.txt
> > @@ -0,0 +1,39 @@
> > +Driver for GE B850v3 LVDS/DP++ display bridge
> > +
> > +Required properties:
> > + - compatible : should be "ge,b850v3-lvds-dp".
>
> Isn't '-lvds-dp' redundant? The part# should be enough.
b850v3 is the name of the product, this is why the proposed name. What about, b850v3-dp2 dp2 indicating the second DP output?
>
> > + - reg : should contain the main address which is used to ack the
> > + interrupts and address for edid.
> > + - reg-names : comma separeted list of register names. Valid values
>
> s/separeted/separated/
argh, sorry for this. Will fix it.
>
> > + are "main", and "edid".
> > + - interrupt-parent : phandle of the interrupt controller that services
> > + interrupts to the device
> > + - interrupts : one interrupt should be described here, as in
> > + <0 IRQ_TYPE_LEVEL_HIGH>.
> > + - port : should describe the video signal connection between the host
> > + and the bridge.
> > +
> > +Example:
> > +
> > +&mux2_i2c2 {
> > + status = "okay";
> > + clock-frequency = <100000>;
> > +
> > + b850v3-lvds-dp-bridge@73 {
> > + compatible = "ge,b850v3-lvds-dp";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + reg = <0x73 0x72>;
> > + reg-names = "main", "edid";
> > +
> > + interrupt-parent = <&gpio2>;
> > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > + port {
> > + b850v3_dp_bridge_in: endpoint {
> > + remote-endpoint = <&lvds0_out>;
> > + };
> > + };
> > + };
> > +};
> > --
> > 2.5.5
> >
next prev parent reply other threads:[~2017-01-03 23:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 20:24 [PATCH V7 0/4] Add driver for GE B850v3 LVDS/DP++ Bridge Peter Senna Tschudin
2017-01-01 20:24 ` [PATCH V7 1/4] Documentation/devicetree/bindings: b850v3_lvds_dp Peter Senna Tschudin
2017-01-03 22:51 ` Rob Herring
2017-01-03 23:34 ` Peter Senna Tschudin [this message]
2017-01-04 20:39 ` Rob Herring
2017-01-07 1:29 ` Peter Senna Tschudin
2017-01-10 21:04 ` Laurent Pinchart
2017-01-16 8:37 ` Peter Senna Tschudin
2017-01-18 21:10 ` Laurent Pinchart
2017-01-19 8:12 ` Peter Senna Tschudin
2017-01-19 8:17 ` Laurent Pinchart
2017-01-19 9:25 ` Peter Senna Tschudin
2017-01-19 11:49 ` Laurent Pinchart
2017-01-10 21:06 ` Laurent Pinchart
2017-01-01 20:24 ` [PATCH V7 2/4] MAINTAINERS: Add entry for GE B850v3 LVDS/DP++ Bridge Peter Senna Tschudin
2017-01-01 20:24 ` [PATCH V7 3/4] drm/bridge: Add driver " Peter Senna Tschudin
2017-01-02 11:26 ` Peter Senna Tschudin
2017-01-05 7:48 ` Archit Taneja
2017-01-28 14:16 ` Peter Senna Tschudin
2017-01-30 17:05 ` Jani Nikula
2017-02-01 9:44 ` Archit Taneja
2017-02-01 10:58 ` Peter Senna Tschudin
2017-02-01 11:35 ` Daniel Vetter
2017-02-01 12:21 ` Peter Senna Tschudin
2017-02-02 9:56 ` Archit Taneja
2017-02-02 1:46 ` Emil Velikov
2017-02-02 11:53 ` Peter Senna Tschudin
2017-02-02 12:37 ` Emil Velikov
2017-02-03 8:00 ` Daniel Vetter
2017-02-03 12:25 ` Emil Velikov
2017-02-06 8:45 ` Daniel Vetter
2017-01-01 20:24 ` [PATCH V7 4/4] dts/imx6q-b850v3: Use " Peter Senna Tschudin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529b-586c3500-5-5e05b080@98620974 \
--to=peter.senna@collabora.co.uk \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=architt@codeaurora.org \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eballetbo@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=fabio.estevam@nxp.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@dowhile0.org \
--cc=jslaby@suse.cz \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=martin.donnelly@ge.com \
--cc=martyn.welch@collabora.co.uk \
--cc=mchehab@osg.samsung.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=peter.senna@collabora.com \
--cc=peter.senna@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=treding@nvidia.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).